Skip to content

feat(bigquery): add support of use_avro_logical_types for extract jobs - #9642

Merged
tswast merged 3 commits into
googleapis:masterfrom
MaxxleLLC:BigQuery_Add_use_avro_logical_types_for_extract_jobs
Nov 20, 2019
Merged

feat(bigquery): add support of use_avro_logical_types for extract jobs#9642
tswast merged 3 commits into
googleapis:masterfrom
MaxxleLLC:BigQuery_Add_use_avro_logical_types_for_extract_jobs

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes#9624

@HemangChothani
HemangChothani requested a review from a teamNovember 8, 2019 11:22
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
@HemangChothani

Copy link
Copy Markdown
ContributorAuthor

kokoro - BigQuery failure related to 9633 issue.

@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once nit is addressed.

Comment threadbigquery/google/cloud/bigquery/job.py Outdated
@plamut

plamut commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

@HemangChothani Thanks for the cleanup, let's add it to the original use_avro_logical_types() method, too (boy scouts and such).

Edit: Great, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for use_avro_logical_types for extract jobs

5 participants

@HemangChothani@plamut@tswast@googlebot@yoshi-kokoro