Skip to content

tests(storage): fix query-string order dependent assert - #9728

Merged
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:9714-storage-fix-qs-order-dependent-assert
Nov 11, 2019
Merged

tests(storage): fix query-string order dependent assert#9728
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:9714-storage-fix-qs-order-dependent-assert

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Note to reviewers: commit-by-commit will make the cleanups / refactorings clearer.

Closes#9714.

@tseavertseaver added api: storage Issues related to the Cloud Storage API. testing labels Nov 11, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2019

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tseaver

@tseaver
tseaver merged commit ce04e30 into googleapis:masterNov 11, 2019
@tseaver
tseaver deleted the 9714-storage-fix-qs-order-dependent-assert branch November 11, 2019 21:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: query string order dependency in 'test_create_bucket_with_string_confict' unit test.

3 participants

@tseaver@frankyn@googlebot