Remove '_implicit_environ' by tseaver · Pull Request #979 · googleapis/google-cloud-python

tseaver · 2015-07-10T18:03:23Z

Uses #978 as a base.

Final cleanup for #944.

dhermes · 2015-07-10T19:01:04Z

Ping me here when #978 is in.

tseaver · 2015-07-10T21:03:44Z

@dhermes I've rebased against the latest in #978. I will rebase again and ping you after it lands on master.

tseaver · 2015-07-11T03:46:00Z

@dhermes now rebased against master, after merging #978.

Update batch/transaction to push themselves onto client's stack, rather than batches. Updated API-invoking methods to take 'client', rather than 'connection', falling back to the client held by self. See #944.

Also remove symbols imported for conveniences from '_implicit_environ'.

…lient'.

tseaver · 2015-07-11T16:58:50Z

@dhermes Rebased after merge of #978 and #982. PTAL

Addresses: #979 (comment)

Addresses: 4a914db#commitcomment-12124183

tseaver · 2015-07-13T18:12:19Z

I'm not as fussy as you about the commit history -- if you'd like, I can just squash the whole PR into a single commit.

dhermes · 2015-07-13T18:18:36Z

I'm not that fussy.

I think re-committing the "Update batch/transaction/query to hold client." commit only to remove those changes later is a bit silly, but not worth arguing over. (Just re-read my comment yesterday, noticed "moral" instead of "normal", unintentionally a bit dramatic by me! Reviews from phone will do that to you.) Your "git style" can lead to issues like that since you always add review changes as new commits. In this case (this PR and #978) you're better off using git cherry-pick on the upstream commits than git rebase.

Code LGTM. Feel free to merge.

Remove '_implicit_environ'

Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>

* fix(deps): require google-cloud-audit-log >= 0.3.1 * update constraints-3.8.txt * remove dev

… RESOURCE_EXHAUSTD (#979) * fix: Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD PiperOrigin-RevId: 557935020 Source-Link: googleapis/googleapis@38e1f31 Source-Link: googleapis/googleapis-gen@5bbe39d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

chore: relocate owl bot post processor

This change allows the user to run a [dry run query](https://docs.cloud.google.com/bigquery/docs/samples/bigquery-query-dry-run?hl=en) using the `read_gbq` function. Instead of returning a `pd.DataFrame`, the behavior is changed and the amount of data processed (in GB) is returned. --------- Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com> Co-authored-by: Shuowei Li <shuowei@google.com> Co-authored-by: Shenyang Cai <sycai@google.com>

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>pandas-gbq: 0.33.0</summary> ## [0.33.0](googleapis/python-bigquery-pandas@v0.32.0...v0.33.0) (2026-01-05) ### Features * add dry run to the read_gbq function (#979) ([516f986f](googleapis/python-bigquery-pandas@516f986f)) </details> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@eaef28e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2015

tseaver mentioned this pull request Jul 10, 2015
Implement "client" pattern for datastore #944
Closed
8 tasks

tseaver added 9 commits July 11, 2015 12:51

Update batch/transaction/query to hold client.
ca42fdf
Update batch/transaction to push themselves onto client's stack, rather than batches. Updated API-invoking methods to take 'client', rather than 'connection', falling back to the client held by self. See #944.

Remove 'gcloud.datastore.set_defaults'.
c16dae4
Also remove symbols imported for conveniences from '_implicit_environ'.

Remove implicit dataset ID lookup from key.
94c9c11

Move dataset ID / connection discovery from '_implicit_environ' to 'c…
dd99e2c
…lient'.

Remove spurious implicit environ testing support.
acde44c

Remove '_implicit_environ' and testing support.
f2c151a

Update system tests to use client in place of '_implicit_envioron.'
4a914db

Undo odd rebase artefacts.
1d9ca7d

Fix coverage lapses induced by merge.
e212d9b

tseaver added 2 commits July 13, 2015 14:06

Nuke used-only-once '_get_connection'.
1b0b19c
Addresses: #979 (comment)

Avoid shadowing 'client' module w/ 'Client' instance.
8423abd
Addresses: 4a914db#commitcomment-12124183

tseaver added a commit that referenced this pull request Jul 13, 2015
Merge pull request#979from tseaver/944-remove__implicit_environ
8373227
Remove '_implicit_environ'

tseaver merged commit 8373227 into googleapis:masterJul 13, 2015

tseaver deleted the 944-remove__implicit_environ branch July 13, 2015 18:20

dhermes mentioned this pull request Jul 21, 2015
Upgrading version to 0.7 #981
Merged

parthea added a commit that referenced this pull request Sep 11, 2025
chore: remove redundant code (#979)
91b934b
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>

parthea added a commit that referenced this pull request Sep 16, 2025
chore: remove redundant code (#979)
fd932eb
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>

parthea pushed a commit that referenced this pull request Nov 22, 2025
fix: improve rowset revision (#979)
48605dd

parthea added a commit that referenced this pull request Nov 24, 2025
fix(deps): require google-cloud-audit-log >= 0.3.1 (#979)
81d78f8
* fix(deps): require google-cloud-audit-log >= 0.3.1 * update constraints-3.8.txt * remove dev

parthea added a commit that referenced this pull request Nov 25, 2025
fix(deps): require google-cloud-audit-log >= 0.3.1 (#979)
90b6fda
* fix(deps): require google-cloud-audit-log >= 0.3.1 * update constraints-3.8.txt * remove dev

parthea pushed a commit that referenced this pull request Mar 2, 2026
fix: improve rowset revision (#979)
2b10897

parthea pushed a commit that referenced this pull request Mar 6, 2026
chore: relocate owl bot post processor (#979)
3489790
chore: relocate owl bot post processor

Navigation Menu

Uh oh!

Remove '_implicit_environ' - #979

Remove '_implicit_environ'#979
tseaver merged 11 commits into
googleapis:masterfrom
tseaver:944-remove__implicit_environ

tseaver commented Jul 10, 2015

Uh oh!

dhermes commented Jul 10, 2015

Uh oh!

tseaver commented Jul 10, 2015

Uh oh!

tseaver commented Jul 11, 2015

Uh oh!

tseaver commented Jul 11, 2015

Uh oh!

tseaver commented Jul 13, 2015

Uh oh!

dhermes commented Jul 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tseaver commented Jul 10, 2015

Uh oh!

dhermes commented Jul 10, 2015

Uh oh!

tseaver commented Jul 10, 2015

Uh oh!

tseaver commented Jul 11, 2015

Uh oh!

tseaver commented Jul 11, 2015

Uh oh!

tseaver commented Jul 13, 2015

Uh oh!

dhermes commented Jul 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants