Uh oh!
There was an error while loading. Please reload this page.
fix(bigquery): import Mapping from collections.abc not from collections - #9826
Conversation
tswast
left a comment
There was a problem hiding this comment.
When was the abc module added? If not until 3.x, we still need to account for compatibility with Python 2.7 for a little while longer.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tswast
left a comment
There was a problem hiding this comment.
Thanks!
Just kicked off the Kokoro CI tests. We can merge, assuming those pass.
samuelcolvin
left a comment
There was a problem hiding this comment.
@tswast I know you like importing modules, not classes, but this is the canonical approach, anything else will be very unclear.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
robert-l1
commented
Dec 13, 2019
I believe this update is causing issues with several versions of the BigQuery client class. My images are now throwing: I see the same in 2.7: |
tkrassowski
commented
Dec 16, 2019
@robert-l1 |
neteler
commented
Jan 8, 2020
FWIW: So far six 1.13.0 is the latest release (https://pypi.org/project/six/) and seems to be sufficient. |
Getting following deprecation warning in Bigquery: