Skip to content

chore(bigquery): run unit tests with Python 3.8 - #9880

Merged
tswast merged 3 commits into
googleapis:masterfrom
tswast:issue9878-bq-3.8
Dec 2, 2019
Merged

chore(bigquery): run unit tests with Python 3.8#9880
tswast merged 3 commits into
googleapis:masterfrom
tswast:issue9878-bq-3.8

Conversation

@tswast

@tswasttswast commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

I had to decrease the required per-version coverage on account of the missing pyarrow dependency.

Towards #9878

Coverage is a bit low because of the missing pyarrow dependency.
@tswast
tswast requested a review from a teamNovember 21, 2019 23:01
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2019
@tswast
tswast requested a review from plamutNovember 21, 2019 23:01
@tswast

Copy link
Copy Markdown
ContributorAuthor

I've filed https://github.com/googleapis/google-cloud-python/issues/9881 to track removing the Python 3.8-specific updates in the noxfile once all dependencies are available.

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, and the tests run under Python 3.8, albeit with a lot of them skipped for the time being.

We might need to lower the coverage threshold, though, I got a coverage failure when running the session unit-3.8 (total coverage 92.90%, required 93%). That was after removing the .coverage file first.

Comment threadbigquery/noxfile.py Outdated
Comment threadbigquery/tests/unit/test__pandas_helpers.py

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional comments look good. 👍

However, I now cannot verify the PR, as the nox setup phase fails with numpy import errors, and complaining that LLVM version 7.0+ is needed (I seem to have 6.0.0 installed).

Could be just my specific environment, but I did not dig further. Could perhaps somebody else try on their machine?

BTW, the coverage check (still) seems to fail on Kokoro...

@tswast

Copy link
Copy Markdown
ContributorAuthor

From Kokoro:

Session unit-3.8 skipped: Python interpreter 3.8 not found.

I'll send a PR to the test containers repo to see if I can get this in our multi-Python image. googleapis/testing-infra-docker#44

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2019
@tswasttswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tswast@plamut@busunkim96@googlebot@yoshi-kokoro