Skip to content

feat(bigquery): add create job method - #9882

Closed
HemangChothani wants to merge 5 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_add_create_job_method
Closed

feat(bigquery): add create job method#9882
HemangChothani wants to merge 5 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_add_create_job_method

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

Fixes #9781

@HemangChothani
HemangChothani requested a review from a teamNovember 22, 2019 05:44
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2019
@HemangChothaniHemangChothani changed the title Bigquery add create job methodfeat(bigquery): add create job methodNov 22, 2019
tswast
tswast reviewed Dec 4, 2019
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/client.py Outdated
job_config (dict): configuration job representation returned from the API.

Keyword Arguments:
source (Union[ \

@tswasttswastDec 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These arguments are quite odd to be including in a generic "create job" function.

Better to add the needed properties to the relevant -JobConfig classes.

@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2019
@HemangChothani

HemangChothani commented Dec 6, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Unit test is failing which is unrelated to these changes. I think it's related to PR 9915.
May i create another PR to fix unit test issue?

@HemangChothani

HemangChothani commented Jan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

@tswast PTAL!

@HemangChothani

HemangChothani commented Feb 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Suppressed by googleapis/python-bigquery#32

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast left review comments

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HemangChothani@tswast@googlebot@yoshi-kokoro