Skip to content

fix(automl): fix TypeError when passing a client_info to automl TablesClient - #9949

Merged
helinwang merged 3 commits into
googleapis:masterfrom
vimota:client_info
Dec 17, 2019
Merged

fix(automl): fix TypeError when passing a client_info to automl TablesClient#9949
helinwang merged 3 commits into
googleapis:masterfrom
vimota:client_info

Conversation

@vimota

@vimotavimota commented Dec 9, 2019

Copy link
Copy Markdown
Contributor

Ensures the ClientInfo object isn't passed in twice to the underlying clients (AutoMLClient and PredictionServiceClient) from the Table Client.

Fixes#9948 🦕

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2019
@vimota

vimota commented Dec 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Cc'ing @helinwang as I was told you are the new maintainer of the library.

helinwang
helinwang reviewed Dec 12, 2019
View reviewed changes
Comment threadautoml/google/cloud/automl_v1beta1/tables/tables_client.py
@@ -104,17 +104,18 @@ def __init__(
else:
client_info_.user_agent = user_agent
client_info_.gapic_version = version

@helinwanghelinwangDec 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I think it's good to encourage being explicit with the argument. E.g., prefer explicit argument than using kwargs.
Instead of removing the client_info argument, could you change the solution to removing "client_info" from kwargs after this line?

@vimotavimotaDec 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@helinwang

helinwang commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

The check is failing on Commit message did not follow Conventional Commits, could you make change to the commit message according to the rule as well? Thanks!

@vimotavimota changed the title Fix TypeError when passing a client_info to automl TablesClientfix(automl): fix TypeError when passing a client_info to automl TablesClientDec 12, 2019
@vimota

vimota commented Dec 12, 2019

Copy link
Copy Markdown
ContributorAuthor

The check is failing on Commit message did not follow Conventional Commits, could you make change to the commit message according to the rule as well? Thanks!

Done!

helinwang
helinwang approved these changes Dec 12, 2019
View reviewed changes

@helinwanghelinwang left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@vimota

vimota commented Dec 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Fix the formatting that failed the test. (running blacken with python version 3.6 failed with No module named 'distutils.spawn' so I had to temporarily run it with 3.7 to fix the lint errors).

@vimota

vimota commented Dec 17, 2019

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 Is it possible to rerun the presubmits? Thanks!

@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019
@busunkim96

busunkim96 commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

@vimota Done!. @helinwang please merge when you are ready to.

@helinwang

helinwang commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

Thanks all!

@helinwang
helinwang merged commit 8bb4068 into googleapis:masterDec 17, 2019
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Oct 21, 2023
@vimota@helinwang
fix(automl): fix TypeError when passing a client_info to automl Table…
bf706fd
…sClient (#9949)
* fix(automl): fix TypeError when passing a client_info to automl TablesClient
The solution is to delete client_info from kwargs instead and pass named parameter.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96busunkim96Awaiting requested review from busunkim96
1 more reviewer
@helinwanghelinwanghelinwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AutoML Tables: Passing client_info produces a a TypeError

5 participants

@vimota@helinwang@busunkim96@googlebot@yoshi-kokoro