Skip to content

chore(pubsub): release 1.1.0 - #9950

Merged
plamut merged 2 commits into
googleapis:masterfrom
pradn:release-pubsub-1.0.3
Dec 10, 2019
Merged

chore(pubsub): release 1.1.0#9950
plamut merged 2 commits into
googleapis:masterfrom
pradn:release-pubsub-1.0.3

Conversation

@pradn

@pradnpradn commented Dec 10, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Release a new version since there have been a few fixes.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@pradnpradn changed the title pubsub(chore): release 1.0.3chore(pubsub): release 1.0.3Dec 10, 2019
plamut
plamut reviewed Dec 10, 2019
View reviewed changes

@plamutplamut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments about the grammar and the semantic version bump, although not super opinionated (feel free to disagree :) )

Edit: Oh, and the commit message should also be amended to follow the guideline (the check currently fails).

Comment threadpubsub/setup.py Outdated
Comment threadpubsub/CHANGELOG.md Outdated
Comment threadpubsub/CHANGELOG.md Outdated
Comment threadpubsub/CHANGELOG.md Outdated
@pradn
Fix commit message formatting. Change version from 1.0.3 to 1.1.0 bec…
85d75bf
…ause the stop method was added to the publisher client.
@pradnpradn changed the title chore(pubsub): release 1.0.3chore(pubsub): release 1.1.0Dec 10, 2019
plamut
plamut approved these changes Dec 10, 2019
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut
plamut merged commit 4d90932 into googleapis:masterDec 10, 2019
@pradn

pradn commented Dec 10, 2019•
edited by plamut
Loading

Copy link
Copy Markdown
ContributorAuthor

Release is at https://github.com/googleapis/google-cloud-python/releases/tag/pubsub-1.1.0

@plamut

plamut commented Dec 10, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@pradn I manually changed the tag and release title to 1.1.0, please check if a manual run is needed to publish the release to PyPI (the bot might be tempted to upload the 1.0.3 tag).

Both tags point to the same commit, though.

@pradn

pradn commented Dec 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Okay, I should have just made a new branch/PR with 1.0.1 to make it simple.

I deleted the 1.0.3 tag in the this repo. The 1.1.0 tag looks good. I added the "autorelease:tagged" flag back on to continue the release to PyPi.

Hopefully everything works now.

@plamut

plamut commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

It appears the bot will have to be run manually, the similar thing happened when releasing API Core recently.

(cc: @busunkim96 )

@busunkim96

busunkim96 commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

Released to pypi: https://pypi.org/project/google-cloud-pubsub/1.1.0

@plamutplamut added the api: pubsub Issues related to the Pub/Sub API. label Jan 21, 2020
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Mar 2, 2026
@pradn@plamut
chore(pubsub): release 1.1.0 (#9950)
fbf9f1c
* Release 1.1.0
* Fix commit message formatting. Change version from 1.0.3 to 1.1.0 because the stop method was added to the publisher client.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneufanguillanneufAwaiting requested review from anguillanneuf
1 more reviewer
@plamutplamutplamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the Pub/Sub API.autorelease: publishedcla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pradn@plamut@busunkim96@googlebot