Skip to content

feat(storage): support optionsRequestedPolicyVersion - #9989

Merged
jkwlui merged 12 commits into
masterfrom
storage-policy-version
Jan 13, 2020
Merged

feat(storage): support optionsRequestedPolicyVersion#9989
jkwlui merged 12 commits into
masterfrom
storage-policy-version

Conversation

@jkwlui

@jkwluijkwlui commented Dec 17, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Requires #9869

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2019
@jkwluijkwlui changed the title Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-cloud-python/issues) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary)feat(storage): support optionsRequestedPolicyVersionDec 17, 2019
@jkwlui
jkwlui changed the base branch from master to iam-proposal3December 17, 2019 20:38
frankyn
frankyn reviewed Dec 17, 2019
View reviewed changes
Comment threadstorage/google/cloud/storage/bucket.py
frankyn
frankyn reviewed Dec 18, 2019
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I have one nit question.

Comment threadstorage/tests/system.py
@jkwlui
iam proposal#3
583ca42
maintain compatibility with defaultdict
remove in place
raise KeyError on delete
update deprecation for dict-key access and factory methods
clean up
maintain compatibility - removing duplicate in __setitems__
check for conditions for dict access
remove empty binding
fix test accessing private var _bindings
fix(tests): change version to make existing tests pass
tests: add tests for getitem, delitem, setitem on v3 and conditions
test policy.bindings property
fixlint
black
sort bindings by role when converting to api repr
add deprecation warning for iam factory methods
update deprecation message for role methods
make Policy#bindings.members a set
update policy docs
fix docs
make docs better
fix: Bigtable policy class to use Policy.bindings
add from_pb with conditions test
add to_pb condition test
blacken
fix policy __delitem__
add docs on dict access
do not modify binding in to_apr_repr
@jkwlui
jkwluiforce-pushed the storage-policy-version branch from 1badb64 to c210d29CompareDecember 19, 2019 21:17
@jkwlui
jkwlui requested a review from frankynDecember 19, 2019 21:19
frankyn
frankyn approved these changes Dec 19, 2019
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jkwluijkwlui added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 19, 2019
crwilcox
crwilcox suggested changes Dec 20, 2019
View reviewed changes
Comment threadapi_core/google/api_core/iam.py Outdated
Comment threadstorage/tests/unit/test_bucket.py
@jkwlui
jkwlui changed the base branch from iam-proposal3 to masterJanuary 9, 2020 21:01
@jkwlui
jkwlui requested review from crwilcox and frankynJanuary 9, 2020 23:46
@jkwlui

jkwlui commented Jan 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@crwilcox fixed the builds. Would you mind taking a look again?

@jkwlui
jkwlui merged commit 9b856cf into masterJan 13, 2020
@jkwlui
jkwlui deleted the storage-policy-version branch January 13, 2020 21:05
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Nov 24, 2025
@jkwlui
feat(storage): support optionsRequestedPolicyVersion (#9989)
77bb915
* iam proposal #3
maintain compatibility with defaultdict
remove in place
raise KeyError on delete
update deprecation for dict-key access and factory methods
clean up
maintain compatibility - removing duplicate in __setitems__
check for conditions for dict access
remove empty binding
fix test accessing private var _bindings
fix(tests): change version to make existing tests pass
tests: add tests for getitem, delitem, setitem on v3 and conditions
test policy.bindings property
fixlint
black
sort bindings by role when converting to api repr
add deprecation warning for iam factory methods
update deprecation message for role methods
make Policy#bindings.members a set
update policy docs
fix docs
make docs better
fix: Bigtable policy class to use Policy.bindings
add from_pb with conditions test
add to_pb condition test
blacken
fix policy __delitem__
add docs on dict access
do not modify binding in to_apr_repr
* feat(storage): support requested_policy_version for get_iam_policy
* add system-test
* add ref doc sample to get_iam_policy
* add requested_policy_version to blob
* fix tests
* nit: typo
* blacken
* fix docs build
* format docs
* remove unused variables
parthea pushed a commit that referenced this pull request Mar 9, 2026
@jkwlui
feat(storage): support optionsRequestedPolicyVersion (#9989)
43f44ba
* iam proposal #3
maintain compatibility with defaultdict
remove in place
raise KeyError on delete
update deprecation for dict-key access and factory methods
clean up
maintain compatibility - removing duplicate in __setitems__
check for conditions for dict access
remove empty binding
fix test accessing private var _bindings
fix(tests): change version to make existing tests pass
tests: add tests for getitem, delitem, setitem on v3 and conditions
test policy.bindings property
fixlint
black
sort bindings by role when converting to api repr
add deprecation warning for iam factory methods
update deprecation message for role methods
make Policy#bindings.members a set
update policy docs
fix docs
make docs better
fix: Bigtable policy class to use Policy.bindings
add from_pb with conditions test
add to_pb condition test
blacken
fix policy __delitem__
add docs on dict access
do not modify binding in to_apr_repr
* feat(storage): support requested_policy_version for get_iam_policy
* add system-test
* add ref doc sample to get_iam_policy
* add requested_policy_version to blob
* fix tests
* nit: typo
* blacken
* fix docs build
* format docs
* remove unused variables
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankynfrankynAwaiting requested review from frankyn
1 more reviewer
@crwilcoxcrwilcoxcrwilcox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkwlui@crwilcox@frankyn@googlebot@yoshi-kokoro