Skip to content

feat: decode uri path components correctly - #913

Merged
chingor13 merged 3 commits into
googleapis:masterfrom
codyoss:generic-url
Dec 17, 2019
Merged

feat: decode uri path components correctly#913
chingor13 merged 3 commits into
googleapis:masterfrom
codyoss:generic-url

Conversation

@codyoss

@codyosscodyoss commented Dec 10, 2019

Copy link
Copy Markdown
Member

The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.

Fixes#398

@codyoss
feat: decode uri path components correctly
875356d
The old implementation was incorrecly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.
Fixesgoogleapis#398
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@codyoss
codyoss marked this pull request as ready for review December 10, 2019 23:03
@codyoss
codyoss requested a review from a teamDecember 10, 2019 23:03
elharo
elharo reviewed Dec 10, 2019
View reviewed changes
Comment threadgoogle-http-client/src/main/java/com/google/api/client/http/GenericUrl.java
Comment threadgoogle-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java Outdated
Comment threadgoogle-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java Outdated
elharo
elharo reviewed Dec 11, 2019
View reviewed changes

@elharoelharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could swear this is reinventing something that exists in Guava, but perhaps that's only in the internal version.

@chingor13
chingor13 merged commit 7d4a048 into googleapis:masterDec 17, 2019
@dmitry-fa

dmitry-fa commented Jan 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

This change caused the problem with using space in object names in java cloud storage:

googleapis/java-storage#53
googleapis/java-storage#57
googleapis/java-storage#121

@athakor

athakor commented Feb 11, 2020

Copy link
Copy Markdown

@dmitry-fa correct, one more issue related to this changes.
googleapis/java-storage#121

@codyoss
codyoss deleted the generic-url branch February 2, 2022 15:52
@mihalyr

mihalyr commented Feb 2, 2022

Copy link
Copy Markdown

Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using google-http-client version 1.34.0 or older that includes this change. The problem is handling + signs in sheet titles that lead to API failures when trying to append cells to a sheet that contains + in the title. This was working well before this change.

It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets.

@mihalyrmihalyr mentioned this pull request Feb 7, 2022
Closed
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-javadoc…
65795ce
…-plugin to v3.4.0 (googleapis#913)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-javadoc-plugin)) | `3.3.2` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/compatibility-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/confidence-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
@ldetmerldetmer mentioned this pull request Apr 18, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13chingor13chingor13 approved these changes
+1 more reviewer
@elharoelharoelharo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GenericUrl converts plus sign into space within URI path component

7 participants

@codyoss@dmitry-fa@athakor@mihalyr@chingor13@elharo@googlebot