Skip to content
This repository was archived by the owner on Sep 9, 2023. It is now read-only.

feat(samples): add remaining featurestore api samples - #974

Merged
alicejli merged 8 commits into
googleapis:mainfrom
sai-chaithu:FeaturestoreSamples
Jul 11, 2022
Merged

feat(samples): add remaining featurestore api samples#974
alicejli merged 8 commits into
googleapis:mainfrom
sai-chaithu:FeaturestoreSamples

Conversation

@sai-chaithu

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #945 ☕️

@sai-chaithu
sai-chaithu requested a review from a teamJune 23, 2022 14:56
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jun 23, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Jun 23, 2022
@snippet-bot

snippet-botBot commented Jun 23, 2022

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelBot added api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. labels Jun 23, 2022
@sai-chaithusai-chaithu changed the title feat(samples): add featurestore samplesfeat(samples): add create, get, list, update feature-store samplesJun 23, 2022
@sai-chaithusai-chaithu changed the title feat(samples): add create, get, list, update feature-store samplesfeat(samples): add remaining featurestore api samplesJun 23, 2022
dizcology
dizcology previously approved these changes Jun 23, 2022
@diemtvudiemtvu self-assigned this Jun 24, 2022
@diemtvudiemtvu added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 24, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2022
diemtvu
diemtvu previously approved these changes Jun 24, 2022
@sai-chaithu
sai-chaithu requested a review from a teamJune 24, 2022 12:51
@diemtvudiemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 24, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot dismissed stale reviews from diemtvu and dizcologyJune 24, 2022 13:28

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 24, 2022
@diemtvudiemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
}
}
}
// [END aiplatform_get_featurestore_sample] No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of the file, here and else where

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the files as suggested

@diemtvudiemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 4, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot dismissed dizcology’s stale reviewJuly 4, 2022 12:52

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 4, 2022
@diemtvudiemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@alicejli

Copy link
Copy Markdown
Contributor

@dizcology do you mind re-reviewing this? Thanks!

@alicejlialicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@kurtisvgkurtisvg removed their assignment Jul 11, 2022
@alicejlialicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@alicejlialicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@alicejlialicejli added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 11, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@alicejli
alicejli merged commit 872efb4 into googleapis:mainJul 11, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Jul 11, 2022
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jul 14, 2022
🤖 I have created a release *beep* *boop*
---
## [3.1.0](v3.0.0...v3.1.0) (2022-07-13)
### Features
* **samples:** add remaining featurestore api samples ([#974](#974)) ([872efb4](872efb4))
* **samples:** added all entity type samples ([#976](#976)) ([b75963f](b75963f))
### Bug Fixes
* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-aiplatform/issues/1485)) ([#991](#991)) ([858e68b](858e68b))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actionsBot pushed a commit to googleapis/google-cloud-java that referenced this pull request Jul 14, 2022
🤖 I have created a release *beep* *boop*
---
## [3.1.0](googleapis/java-aiplatform@v3.0.0...v3.1.0) (2022-07-13)
### Features
* **samples:** add remaining featurestore api samples ([#974](googleapis/java-aiplatform#974)) ([99ea51d](googleapis/java-aiplatform@99ea51d))
* **samples:** added all entity type samples ([#976](googleapis/java-aiplatform#976)) ([f496d8a](googleapis/java-aiplatform@f496d8a))
### Bug Fixes
* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-aiplatform/issues/1485)) ([#991](googleapis/java-aiplatform#991)) ([c41d394](googleapis/java-aiplatform@c41d394))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: vertex-aiIssues related to the googleapis/java-aiplatform API.samplesIssues that are directly related to samples.size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sample snippets for Vertex Feature Store

6 participants

@sai-chaithu@alicejli@dizcology@diemtvu@kurtisvg@yoshi-kokoro