feat: migrate to OTEL and enable metrics by default by mutianf · Pull Request #2166 · googleapis/java-bigtable

mutianf · 2024-03-13T01:31:06Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Rollback plan is reviewed and LGTMed
All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

* feat: migrate exporter to OTEL * address comments * filter out only bigtable metrics * fix test * use the bom * update * update * update completeResultCode * add a comment * address comments * address comments * update pom * small fix * also check timestamp * address comment * updates * update * do not block on shutdown

* feat: migrate exporter to OTEL * address comments * filter out only bigtable metrics * fix test * use the bom * update * update * feat: migrate builtin metrics to OTEl * update completeResultCode * add a comment * udpate * fix tests * remove unrelated changes * fix tests * add documentation * fix test * merge exporter changes * address comments * rebase on otel * revert changes in stats * fix import * update * merge back the endpoint change * refactor constants and settings * refactor and fix tests * remove unused dependency * add some javadoc * address part of the comments * update test * test with nano * measure everything in nanos and publish with double histogram * address comments * fix test * add toString

* feat: migrate per connection error count metric to otel * update test * address comments * remove unnecessary check * clean up statsRecorder * remove dependency * address comments

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…to otel

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…to otel

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…to otel

mutianf · 2024-04-12T13:58:30Z

/gcbrun

mutianfand others added 11 commits January 23, 2024 10:07

chore: refactor factory class (#2081)
beb0219

chore: refactor TracerFactory creation (#2102)
b8fd4d5

Merge branch 'main' into otel
5e4eb51

merge from main
65493e7

feat: migrate per connection error count metric to otel (#2133)
cd3467c
* feat: migrate per connection error count metric to otel * update test * address comments * remove unnecessary check * clean up statsRecorder * remove dependency * address comments

feat: migrate per connection error exporter to otel (#2152)
eb46d54

chore: clean up stats package (#2163)
15fb42c

🦉 Updates from OwlBot post-processor
9d5eb08
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into otel
b35d956

mutianf requested review from a teamMarch 13, 2024 01:31

product-auto-labelBot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 13, 2024

mutianf force-pushed the otel branch from 7b2f1d6 to b35d956Compare March 13, 2024 01:52

mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024

mutianf force-pushed the otel branch from 30ffb5a to f9480e8Compare March 14, 2024 23:00

fix clirr and integration test
da09fae

mutianf force-pushed the otel branch from f9480e8 to da09faeCompare March 14, 2024 23:01

fix clirr and integration test
15c28ee

mutianf force-pushed the otel branch from da09fae to 15c28eeCompare March 14, 2024 23:02

gcf-owl-botBot added 2 commits March 14, 2024 23:03

🦉 Updates from OwlBot post-processor
618ba7f
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'otel' ofhttps://github.com/googleapis/java-bigtablein…
f383e33
…to otel

rkaregar approved these changes Mar 15, 2024
View reviewed changes

log more information on test failures
f0b458b

mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2024

Merge branch 'main' into otel
f07a64b

mutianfand others added 3 commits March 18, 2024 15:58

address comments
452571e

🦉 Updates from OwlBot post-processor
970f4f7
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

include version
29cd9ae

mutianf force-pushed the otel branch from 9c89817 to 29cd9aeCompare March 19, 2024 18:43

mutianf added 6 commits March 19, 2024 15:16

fix flaky test
98aef25

Merge branch 'main' into otel
2e26e20

remove otel dependencies since they're added to shared dependencies
377d385

Merge branch 'main' into otel
388cd71

backport new tests since 2.37
b816dda

set feature flag when metrics is enabled
21cad39

mutianf force-pushed the otel branch from d23374b to ecf3acdCompare March 29, 2024 19:10

record metrics whenever it's registered
1f291fb

mutianf force-pushed the otel branch from 52ecb71 to 1f291fbCompare March 29, 2024 19:39

record metrics whenever it's registered
56d55cb

mutianf force-pushed the otel branch from 1f291fb to 56d55cbCompare March 29, 2024 19:41

gcf-owl-botBot added 4 commits March 29, 2024 19:42

🦉 Updates from OwlBot post-processor
59a05f4
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'otel' ofhttps://github.com/googleapis/java-bigtablein…
b890843
…to otel

🦉 Updates from OwlBot post-processor
5349c2b
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'otel' ofhttps://github.com/googleapis/java-bigtablein…
a6c0d91
…to otel

igorbernstein2 reviewed Apr 2, 2024
View reviewed changes

Comment thread...igtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsView.java Outdated

igorbernstein2 approved these changes Apr 2, 2024
View reviewed changes

mutianf added 3 commits April 2, 2024 15:31

remove stale reference
f00e838

clean up
b330948

Merge branch 'main' into otel
a2423ec

mutianf merged commit 1682939 into mainApr 12, 2024

mutianf deleted the otel branch April 12, 2024 14:09

release-pleaseBot mentioned this pull request Apr 5, 2024
chore(main): release 2.38.0 #2188
Merged

robwil mentioned this pull request Oct 16, 2024
[java-bigtable] add bigtable_table_id attribute to opencensus stats / traces googleapis/google-cloud-java#13085
Open

release-pleaseBot mentioned this pull request Dec 15, 2025
chore(protobuf-4.x-rc): release 2.71.0-rc1 #2726
Merged

Navigation Menu

Uh oh!

feat: migrate to OTEL and enable metrics by default - #2166

feat: migrate to OTEL and enable metrics by default#2166
mutianf merged 35 commits into
mainfrom
otel

mutianf commented Mar 13, 2024

Uh oh!

Uh oh!

mutianf commented Apr 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mutianf commented Mar 13, 2024

Uh oh!

Uh oh!

mutianf commented Apr 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants