Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: use service name as the default audience - #2579

Merged
mutianf merged 15 commits into
googleapis:mainfrom
mutianf:jwt
May 6, 2025
Merged

fix: use service name as the default audience#2579
mutianf merged 15 commits into
googleapis:mainfrom
mutianf:jwt

Conversation

@mutianf

@mutianfmutianf commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf
mutianf requested review from a teamApril 30, 2025 15:10
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 30, 2025
@mutianfmutianf changed the title fix: move patch credentials to test envfix: use service name as the default audienceApr 30, 2025
igorbernstein2
igorbernstein2 suggested changes May 6, 2025
View reviewed changes
Comment thread...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
igorbernstein2
igorbernstein2 suggested changes May 6, 2025
View reviewed changes
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java Outdated
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java Outdated
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Comment thread...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java Outdated
igorbernstein2
igorbernstein2 approved these changes May 6, 2025
View reviewed changes
Comment thread...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettingsTest.java Outdated
@mutianf
mutianf merged commit af6d7bd into googleapis:mainMay 6, 2025
@mutianf
mutianf deleted the jwt branch May 6, 2025 19:00
@release-pleaserelease-pleaseBot mentioned this pull request May 6, 2025
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request May 8, 2025
@release-please
chore(main): release 2.58.2 (#2575)
9709ac4
🤖 I have created a release *beep* *boop*
---
## [2.58.2](https://togithub.com/googleapis/java-bigtable/compare/v2.58.1...v2.58.2) (2025-05-08)
### Bug Fixes
* Use service name as the default audience ([#2579](https://togithub.com/googleapis/java-bigtable/issues/2579)) ([af6d7bd](https://togithub.com/googleapis/java-bigtable/commit/af6d7bd28d9d7a4ebb90825a9b4b8a73d63172f6))
### Dependencies
* Update shared dependencies ([#2565](https://togithub.com/googleapis/java-bigtable/issues/2565)) ([043f11b](https://togithub.com/googleapis/java-bigtable/commit/043f11b16948c338096d9407de1e99f02656169e))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-pleaserelease-pleaseBot mentioned this pull request Dec 15, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@igorbernstein2igorbernstein2igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf@igorbernstein2