Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 8, 2026. It is now read-only.
samples: Add example on creating instance with tags - #2837
Merged
Conversation
KasiaStrz
suggested changes
Mar 10, 2026
Comment on lines
+152
to
+153
| * <p>Tags are a way to organize and govern resources across Google Cloud, see: | ||
| * https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing |
There was a problem hiding this comment.
Replace addresses with Markdown links: [Creating and managing tags](https://docs.cloud.google.com/bigtable/docs/tags), same change on lines 158, 159.
Correct links are: https://docs.cloud.google.com/bigtable/docs/tags, https://docs.cloud.google.com/resource-manager/docs/tags/tags-overview
Uh oh!
There was an error while loading. Please reload this page.
| * https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing | ||
| * | ||
| * | ||
| * NOTE: Unlike Labels, a Tag (Key and Value) must be created before it can be |
There was a problem hiding this comment.
Nit: labels, tag, key, value are not proper names, hence we spell them in lowercase.
| * https://docs.cloud.google.com/bigtable/docs/tags for more information. | ||
| */ | ||
| public void createProdInstanceWithTags() { | ||
| // Checks if instance exists, creates instance if does not exists. |
dohun-dev
marked this pull request as ready for review
March 10, 2026 17:48
dohun-devforce-pushed
the
docs2
branch
2 times, most recently
from
April 9, 2026 20:52
851c7eb to
984a1d0Comparemutianf
reviewed
Apr 13, 2026
| public void run() { | ||
| createProdInstance(); | ||
| /* * OPTIONAL: Testing with tags |
Contributor
There was a problem hiding this comment.
Alternatively, can we pass in an additional argument in main() to create instance with tag?
And looks like createProdInstance() and createProdInstanceWithTags are almost identical. I think you can pass the bool as an param:
main(String[] args) {
String projectId = args[0];
boolean createWithTag = false;
if (args.size() > 1) {
boolean createWithTag = Boolean.parseBoolean(args[1]);
}
... instanceAdmin.run(createWithTag);
}
run(boolean createWithTag) {
createProdInstance(createWithTag);
...
}
createProdInstance(boolean createWithTag) {
...
Instance.Builder instanceObjBuilder =
Instance.newBuilder()
.setDisplayName(instanceId)
.setType(Instance.Type.PRODUCTION)
.putLabels("department", "accounting");
if (createWithTag) {
instanceObjBuilder.putTags(tagKey, tagValue);
}
Instance instanceObj = instanceObjBuilder.build()
...
}
ContributorAuthor
There was a problem hiding this comment.
That sounds good. I made the change. Also, this PR is dependent on #2832. Should that version update to 2.75 in the pom.xml file be included in this CL or is that usually done separately?
mutianf
approved these changes
May 4, 2026
mutianf
commented
May 5, 2026
Contributor
/gcbrun |
nimf
approved these changes
May 5, 2026
mutianf
commented
May 5, 2026
Contributor
/gcbrun |
dohun-dev
commented
May 5, 2026
ContributorAuthor
/gcbrun |
KasiaStrz
approved these changes
May 6, 2026
mutianf
commented
May 6, 2026
Contributor
/gcbrun |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.
This is dependent on 2.75.0 #2832