Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies - #350

Merged
kolea2 merged 2 commits into
googleapis:masterfrom
yangnuoyu:master
Aug 31, 2020
Merged

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies#350
kolea2 merged 2 commits into
googleapis:masterfrom
yangnuoyu:master

Conversation

@yangnuoyu

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2020
@codecov

codecovBot commented Jun 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #350 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #350 +/- ##
============================================
- Coverage 80.26% 80.24% -0.02% 
Complexity 1102 1102 ============================================
Files 105 105 Lines 6815 6815 Branches 364 364 ============================================
- Hits 5470 5469 -1 - Misses 1146 1148 +2 + Partials 199 198 -1 
Impacted FilesCoverage ΔComplexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java58.26% <0.00%> (-0.87%)14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848affb...ffa5abf. Read the comment docs.

@yangnuoyu
yangnuoyu marked this pull request as ready for review June 19, 2020 06:02
@igorbernstein2

Copy link
Copy Markdown
Contributor

Please attach a diff of how the dependencies change for end users

stephaniewang526
stephaniewang526 previously approved these changes Jun 22, 2020
kolea2
kolea2 previously requested changes Jun 22, 2020

@kolea2kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review once looking at diff

@stephaniewang526

Copy link
Copy Markdown

Please attach a diff of how the dependencies change for end users

@igorbernstein2 there is no change in dependency list for end users -- i added a kokoro check for this in dependencies.sh to ensure accuracy. The only difference is that transitive dependencies are resolved to be direct. i will share my doc with you for further details. Thanks.

@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Aug 21, 2020
@igorbernstein2

Copy link
Copy Markdown
Contributor

Looking at the main artifact, the proposed change will affect the following deps (by pulling them up to the top level).

[INFO] | \- javax.annotation:javax.annotation-api:jar:1.3.2:compile
[INFO] | +- com.google.http-client:google-http-client:jar:1.36.0:compile
[INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.12:compile
[INFO] | | | +- commons-logging:commons-logging:jar:1.2:compile
[INFO] | | | \- commons-codec:commons-codec:jar:1.11:compile
[INFO] | | +- org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[INFO] | | \- io.opencensus:opencensus-contrib-http-util:jar:0.24.0:compile
[INFO] | \- com.google.http-client:google-http-client-jackson2:jar:1.36.0:compile
[INFO] | \- com.fasterxml.jackson.core:jackson-core:jar:2.11.1:compile
[INFO] | +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] | +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] | +- org.checkerframework:checker-compat-qual:jar:2.5.5:compile
[INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.4.0:compile
[INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile
[INFO] | \- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] | +- org.apache.commons:commons-lang3:jar:3.5:runtime
[INFO] | \- org.conscrypt:conscrypt-openjdk-uber:jar:2.2.1:runtime
[INFO] | \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.19:runtime

This means that those libraries might change version in customer applications if bigtable was tied for a version. But I dont see any tangible negative effects that this would have.

I think we can probably merge

@kolea2kolea2 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2020
@kolea2kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2020
@kolea2
kolea2 merged commit 2298596 into googleapis:masterAug 31, 2020
gcf-merge-on-greenBot pushed a commit that referenced this pull request Sep 2, 2020
🤖 I have created a release \*beep\* \*boop\* ---
## [1.15.0](https://www.github.com/googleapis/java-bigtable/compare/v1.14.0...v1.15.0) (2020-09-01)
### Features
* extend channel priming logic to also send fake requests ([#398](https://www.github.com/googleapis/java-bigtable/issues/398)) ([6f1ead2](https://www.github.com/googleapis/java-bigtable/commit/6f1ead2097150a87cb9712bcf35c6eaa9d57440c))
* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#350](https://www.github.com/googleapis/java-bigtable/issues/350)) ([2298596](https://www.github.com/googleapis/java-bigtable/commit/2298596dab8a1ef87c0f48d3abe8bc3955417eb1))
### Bug Fixes
* temporarily disable reporting to unblock releases ([#395](https://www.github.com/googleapis/java-bigtable/issues/395)) ([a56a0f8](https://www.github.com/googleapis/java-bigtable/commit/a56a0f8c9caf675b68d02587b042e1feeb261ccb))
### Dependencies
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#377](https://www.github.com/googleapis/java-bigtable/issues/377)) ([bdae336](https://www.github.com/googleapis/java-bigtable/commit/bdae336074d80815dcaaf8c71befafc0ed66c079))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#402](https://www.github.com/googleapis/java-bigtable/issues/402)) ([08f7d84](https://www.github.com/googleapis/java-bigtable/commit/08f7d84333c6a74bf03e0a57707b878a29400dd4))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@yangnuoyu@igorbernstein2@stephaniewang526@kolea2@googlebot@yoshi-kokoro