Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

fix: docs of com.google.cloud.Timestamp.parseTimestamp - #258

Merged
athakor merged 3 commits into
googleapis:masterfrom
athakor:core-254
Jul 24, 2020
Merged

fix: docs of com.google.cloud.Timestamp.parseTimestamp#258
athakor merged 3 commits into
googleapis:masterfrom
athakor:core-254

Conversation

@athakor

Copy link
Copy Markdown
Contributor

Fixes#254

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
@athakor
athakor requested a review from chingor13July 22, 2020 14:25
@codecov

codecovBot commented Jul 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #258 +/- ##
=========================================
Coverage 67.62% 67.62% Complexity 384 384 =========================================
Files 36 36 Lines 1986 1986 Branches 269 269 =========================================
Hits 1343 1343 Misses 535 535 Partials 108 108 
Impacted FilesCoverage ΔComplexity Δ
...core/src/main/java/com/google/cloud/Timestamp.java90.62% <ø> (ø)26.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54944c8...2feb8b1. Read the comment docs.

@athakor

Copy link
Copy Markdown
ContributorAuthor

@chingor13 PTAL

@athakor
athakor requested a review from elharoJuly 24, 2020 15:11
@athakor
athakor merged commit 964dd14 into googleapis:masterJul 24, 2020
gcf-merge-on-greenBot pushed a commit that referenced this pull request Aug 12, 2020
🤖 I have created a release \*beep\* \*boop\* ---
### [1.93.8](https://www.github.com/googleapis/java-core/compare/v1.93.7...v1.93.8) (2020-08-12)
### Bug Fixes
* docs of com.google.cloud.Timestamp.parseTimestamp ([#258](https://www.github.com/googleapis/java-core/issues/258)) ([964dd14](https://www.github.com/googleapis/java-core/commit/964dd142609ae8923a285e20746ce9ee8c302bd5))
### Dependencies
* update core dependencies ([#263](https://www.github.com/googleapis/java-core/issues/263)) ([44023c3](https://www.github.com/googleapis/java-core/commit/44023c34d0b5d1990c5028f6e04479b8d7539e77))
* update dependency com.google.api-client:google-api-client-bom to v1.30.10 ([#253](https://www.github.com/googleapis/java-core/issues/253)) ([0fd53fe](https://www.github.com/googleapis/java-core/commit/0fd53fe522e35fdd09783bb618ff7dcf01d82a95))
* update dependency com.google.api:api-common to v1.10.0 ([#261](https://www.github.com/googleapis/java-core/issues/261)) ([1414e01](https://www.github.com/googleapis/java-core/commit/1414e01a8154533d53911933eb86fc785760af6c))
* update dependency com.google.api.grpc:proto-google-common-protos to v1.18.1 ([#268](https://www.github.com/googleapis/java-core/issues/268)) ([b59a83c](https://www.github.com/googleapis/java-core/commit/b59a83c212f862043de0f5f8fa6ae7bb5d2baba4))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1 ([#269](https://www.github.com/googleapis/java-core/issues/269)) ([fe3987e](https://www.github.com/googleapis/java-core/commit/fe3987e2dffb2fe7b7bdd0d48266eba7aad7929b))
* update dependency com.google.protobuf:protobuf-bom to v3.12.4 ([#262](https://www.github.com/googleapis/java-core/issues/262)) ([2ffca65](https://www.github.com/googleapis/java-core/commit/2ffca65399a716a0b929ae3f1ae388481b187ae2))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing documentation for com.google.cloud.Timestamp.parseTimestamp

2 participants

@athakor@elharo