Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Increase DEFAULT_CHUNK_SIZE to reduce transfer overhead - #87

Merged
elharo merged 1 commit into
googleapis:masterfrom
domZippilli:master
Dec 13, 2019
Merged

Increase DEFAULT_CHUNK_SIZE to reduce transfer overhead#87
elharo merged 1 commit into
googleapis:masterfrom
domZippilli:master

Conversation

@domZippilli

Copy link
Copy Markdown
Contributor

Fixes#86 by setting the DEFAULT_CHUNK_SIZE to 15MiB.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2019
@kokoro-teamkokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 4, 2019

@elharoelharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks com.google.cloud.BaseWriteChannelTest

@domZippilli
domZippilliforce-pushed the master branch 2 times, most recently from 7303d92 to 6f0abcdCompareDecember 5, 2019 20:37
@codecov

codecovBot commented Dec 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #87 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #87 +/- ##
============================================
+ Coverage 66.32% 66.46% +0.14% + Complexity 367 362 -5 
============================================
Files 34 34 Lines 1865 1858 -7 Branches 236 234 -2 ============================================
- Hits 1237 1235 -2 + Misses 526 521 -5 
Partials 102 102
Impacted FilesCoverage ΔComplexity Δ
...c/main/java/com/google/cloud/BaseWriteChannel.java36.5% <ø> (ø)18 <0> (ø)⬇️
.../com/google/cloud/MonitoredResourceDescriptor.java83.76% <0%> (-0.28%)20% <0%> (-4%)
...a/com/google/cloud/testing/BaseEmulatorHelper.java31.21% <0%> (-0.22%)5% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java41.66% <0%> (+0.75%)29% <0%> (-1%)⬇️
...re/src/main/java/com/google/cloud/RetryHelper.java53.84% <0%> (+3.84%)2% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5128bd4...cd4f8ed. Read the comment docs.

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @domZippilli!

@domZippilli

Copy link
Copy Markdown
ContributorAuthor

Hey just wanted to check in -- are there any steps I need to take to move this forward?

@elharoelharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn FYI, you need to select the approve button in Github. Unlike google3, LGTM in a comment doesn't suffice.

@frankyn

frankyn commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

I did approve, but my approval doesn't count IIUC. Also I can't merge, could you help merge the PR as well @elharo?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase DEFAULT_CHUNK_SIZE to reduce transfer overhead, increase throughput

6 participants

@domZippilli@frankyn@elharo@chingor13@googlebot@kokoro-team