Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: support overriding the emulator download URL in LocalDatastoreHelper - #492

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
aristide-n:custom-emulator-urls
Aug 26, 2021
Merged

feat: support overriding the emulator download URL in LocalDatastoreHelper#492
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
aristide-n:custom-emulator-urls

Conversation

@aristide-n

Copy link
Copy Markdown
Contributor

Fixes#376

@product-auto-labelproduct-auto-labelBot added the api: datastore Issues related to the googleapis/java-datastore API. label Aug 9, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@aristide-n
aristide-n marked this pull request as draft August 9, 2021 16:51
}
DownloadableEmulatorRunner downloadRunner =
new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM);
new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM, ACCESS_TOKEN);

@aristide-naristide-nAug 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a google-java-core dependency version that contains googleapis/java-core#513

lesv pushed a commit to googleapis/java-core that referenced this pull request Aug 16, 2021
…513)
* feat: support downloading an emulator from an access controlled URL
fixesgoogleapis/java-datastore#376
used in googleapis/java-datastore#492
* fix format
@aristide-n
aristide-n marked this pull request as ready for review August 16, 2021 23:17
@lesvlesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@lesv

lesv commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

/gcbrun

@lesvlesv added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2021
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@chingor13chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 76397bf into googleapis:masterAug 26, 2021
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Sep 1, 2021
suztomo pushed a commit to googleapis/sdk-platform-java that referenced this pull request Mar 21, 2023
…513)
* feat: support downloading an emulator from an access controlled URL
fixesgoogleapis/java-datastore#376
used in googleapis/java-datastore#492
* fix format
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastoreIssues related to the googleapis/java-datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalDatastoreHelper fails to start if used in an environment that cannot access the "gcd" GCS bucket

4 participants

@aristide-n@lesv@chingor13@yoshi-kokoro