Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: Expose Datastore Admin generated client - #748

Merged
kolea2 merged 5 commits into
googleapis:mainfrom
pcostell:owl
May 31, 2022
Merged

feat: Expose Datastore Admin generated client#748
kolea2 merged 5 commits into
googleapis:mainfrom
pcostell:owl

Conversation

@pcostell

@pcostellpcostell commented May 25, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels May 25, 2022
@generated-files-bot

generated-files-botBot commented May 25, 2022

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/proto/google/datastore/v1/entity.proto

@pcostell
pcostellforce-pushed the owl branch 5 times, most recently from 75816ce to 384c707CompareMay 25, 2022 18:40
@pcostell
pcostell marked this pull request as ready for review May 25, 2022 20:09
@pcostell
pcostell requested review from a teamMay 25, 2022 20:09
@kolea2kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@kolea2kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@pcostellpcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@pcostell
pcostellforce-pushed the owl branch 2 times, most recently from d71f4dc to e5b016eCompareMay 27, 2022 04:07
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. size: xl Pull request size is extra large. and removed size: xl Pull request size is extra large. size: s Pull request size is small. labels May 27, 2022
@pcostellpcostell changed the title feat: Expose gapic & grpc clients for Datastore V1.feat: Expose Datastore Admin clientMay 27, 2022
@pcostellpcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@pcostell
pcostellforce-pushed the owl branch 2 times, most recently from 26638cc to 14e7b8aCompareMay 27, 2022 16:35
kolea2
kolea2 reviewed May 27, 2022
View reviewed changes
Comment threadgrpc-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/DatastoreGrpc.java Outdated
Comment thread.repo-metadata.json
@pcostell
pcostellforce-pushed the owl branch 3 times, most recently from a81ab5a to 32b1d7aCompareMay 27, 2022 19:11
@pcostellpcostell added the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@pcostell
feat: Publish gapic admin client.
9a81c18
@pcostell
chore: Run owl manually.
6ffb2dd
Correct missing dependencies not generated by owl.
@pcostellpcostell added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 27, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@pcostell

pcostell commented May 27, 2022

Copy link
Copy Markdown
ContributorAuthor

I think actually ready for review now @kolea2, thanks for your help!

@kolea2kolea2 changed the title feat: Expose Datastore Admin clientfeat: Expose Datastore Admin generated clientMay 31, 2022
kolea2
kolea2 reviewed May 31, 2022
View reviewed changes

@kolea2kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, one comment/question. Thanks!

Comment threadpom.xml Outdated
@kolea2kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
@kolea2
kolea2 merged commit 3dd882a into googleapis:mainMay 31, 2022
This was referenced May 31, 2022
Closed
Merged
@kolea2kolea2 mentioned this pull request May 31, 2022
Closed
gcf-merge-on-greenBot pushed a commit that referenced this pull request May 31, 2022
@release-please
chore(main): release 2.6.0 (#756)
6e6cd3f
🤖 I have created a release *beep* *boop*
---
## [2.6.0](v2.5.1...v2.6.0) (2022-05-31)
### Features
* Expose Datastore Admin generated client ([#748](#748)) ([3dd882a](3dd882a))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@fkorotkov

fkorotkov commented Nov 24, 2022

Copy link
Copy Markdown

Can we do the same for the regular Datastore client? There is no grpc-google-cloud-datastore-v1 unfortunetly.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kolea2kolea2kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastoreIssues related to the googleapis/java-datastore API.size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcostell@fkorotkov@kolea2@yoshi-kokoro