Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 6, 2026. It is now read-only.
chore: Migrate logging synth.py to bazel - #124
Merged
Merged
Conversation
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: googleapis#111
vam-google
commented
Mar 30, 2020
ContributorAuthor
@chingor13 PTAL |
chingor13
approved these changes
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@## master #124 +/- ##
=========================================
Coverage 76.82% 76.82% Complexity 530 530 =========================================
Files 42 42 Lines 3318 3318 Branches 212 212 =========================================
Hits 2549 2549 Misses 626 626 Partials 143 143 Continue to review full report at Codecov.
|
yoshi-automation added a commit
that referenced
this pull request
Mar 30, 2020
c983911 commit c983911 Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Mon Mar 30 13:47:15 2020 -0700 chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation added a commit
that referenced
this pull request
Apr 10, 2020
Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911 Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Mon Mar 30 13:47:15 2020 -0700 Original-Commit-Message: chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation added a commit
that referenced
this pull request
Apr 10, 2020
Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911 Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Mon Mar 30 13:47:15 2020 -0700 Original-Commit-Message: chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation added a commit
that referenced
this pull request
Apr 15, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
yoshi-automation added a commit
that referenced
this pull request
Apr 16, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
yoshi-automation added a commit
that referenced
this pull request
Apr 16, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration.
There is already an open PR with those braking changes: #111