Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

chore: update README - #814

Merged
minherz merged 3 commits into
minherz/structured_loggingfrom
minherz/structured_logging_readme
Jan 5, 2022
Merged

chore: update README#814
minherz merged 3 commits into
minherz/structured_loggingfrom
minherz/structured_logging_readme

Conversation

@minherz

Copy link
Copy Markdown
Contributor

add short description about automatic metadata population and redirection of JUL logs to stdout to README.

@minherz
minherz requested review from a teamJanuary 2, 2022 14:39
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Jan 2, 2022
@minherz
minherz requested a review from losalexJanuary 2, 2022 14:39
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/java-logging API. label Jan 2, 2022
@minherzminherz self-assigned this Jan 2, 2022

@losalexlosalex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update instructions about manual context usage with samples about configuring inherited context.

Comment thread.readme-partials.yaml Outdated
Comment thread.readme-partials.yaml
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 3, 2022
@minherz
minherz requested a review from losalexJanuary 4, 2022 07:50
@minherz
minherzforce-pushed the minherz/structured_logging branch from 5f484a7 to f9bda3dCompareJanuary 4, 2022 17:01

@losalexlosalex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some extra comments - please take a look

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java Outdated
Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java Outdated
add short description about automatic metadata population
and redirection of JUL logs to stdout to README.
change the order of options to manage the context.
describe configuration to enable inheriting context in child scopes (threads).
@minherz
minherzforce-pushed the minherz/structured_logging_readme branch from f9896ef to 1f6f281CompareJanuary 5, 2022 08:36
reverse the use of 'appendComma' flag
rename populateMetadata? flags to make the logic clear
@minherz
minherz merged commit c8b0ee8 into minherz/structured_loggingJan 5, 2022
@minherz
minherz deleted the minherz/structured_logging_readme branch January 5, 2022 11:57
@minherz
minherz restored the minherz/structured_logging_readme branch January 6, 2022 11:27
minherz added a commit that referenced this pull request Jan 6, 2022
@minherzminherz mentioned this pull request Jan 6, 2022
minherz added a commit that referenced this pull request Jan 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: loggingIssues related to the googleapis/java-logging API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@minherz@losalex@simonz130