Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

feat: Add flow control support to publisher - #119

Merged
kamalaboulhosn merged 2 commits into
googleapis:masterfrom
kamalaboulhosn:master
Mar 25, 2020
Merged

feat: Add flow control support to publisher#119
kamalaboulhosn merged 2 commits into
googleapis:masterfrom
kamalaboulhosn:master

Conversation

@kamalaboulhosn

Copy link
Copy Markdown
Contributor

Fixes#25

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@codecov

codecovBot commented Mar 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #119 into master will increase coverage by 0.19%.
The diff coverage is 84.84%.

Impacted file tree graph

@@ Coverage Diff @@## master #119 +/- ##
============================================
+ Coverage 79.36% 79.56% +0.19% - Complexity 305 308 +3 
============================================
Files 21 21 Lines 2603 2701 +98 Branches 115 133 +18 ============================================
+ Hits 2066 2149 +83 - Misses 467 477 +10 - Partials 70 75 +5 
Impacted FilesCoverage ΔComplexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java87.96% <84.53%> (-1.14%)46.00 <5.00> (+3.00)⬇️
...gle/cloud/pubsub/v1/SequentialExecutorService.java91.01% <100.00%> (+0.20%)0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6783ec...6bb47bc. Read the comment docs.

@hannahrogers-googlehannahrogers-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of comments, nothing major

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud Pub/Sub API ignores FlowControlSettings in BatchingSettings

3 participants

@kamalaboulhosn@hannahrogers-google@googlebot