samples: Schema evolution by kamalaboulhosn · Pull Request #1469 · googleapis/java-pubsub

kamalaboulhosn · 2023-01-23T16:48:05Z

No description provided.

snippet-bot · 2023-01-23T16:48:11Z

Here is the summary of changes.

You are about to add 9 region tags.

samples/snippets/src/main/java/pubsub/CommitAvroSchemaExample.java:19, tag pubsub_commit_avro_schema
samples/snippets/src/main/java/pubsub/CommitProtoSchemaExample.java:19, tag pubsub_commit_proto_schema
samples/snippets/src/main/java/pubsub/CreateTopicWithSchemaRevisionsExample.java:19, tag pubsub_create_topic_with_schema_revisions
samples/snippets/src/main/java/pubsub/DeleteSchemaRevisionExample.java:19, tag pubsub_delete_schema_revision
samples/snippets/src/main/java/pubsub/GetSchemaRevisionExample.java:19, tag pubsub_get_schema_revision
samples/snippets/src/main/java/pubsub/ListSchemaRevisionsExample.java:19, tag pubsub_list_schema_revisions
samples/snippets/src/main/java/pubsub/RollbackSchemaExample.java:19, tag pubsub_rollback_schema
samples/snippets/src/main/java/pubsub/SubscribeWithAvroSchemaRevisionsExample.java:19, tag pubsub_subscribe_avro_records_with_revisions
samples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java:19, tag pubsub_update_topic_schema

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

Sita04 · 2023-01-26T16:26:12Z

@kamalaboulhosn Samples failing test and checkstyle.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…apis/java-pubsub into schema-evolution-examples

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

acocuzzo

Left a couple comments re: exceptions, otherwise looks great! Thanks.

acocuzzo · 2023-03-11T01:05:31Z

+ System.out.println("Committed a schema using an Avro schema:\n" + schema);
+ return schema;
+ } catch (AlreadyExistsException e) {
+ System.out.println(schemaName + "already exists.");


We should probably change to FailedPrecondition/InvalidArgument/NotFound/ResourceExhausted, since we can't get AlreadyExists.

acocuzzo · 2023-03-11T01:06:40Z

+
+ System.out.println("Committed a schema using a protobuf schema:\n" + schema);
+ return schema;
+ } catch (AlreadyExistsException e) {


The design is based on SubscribeWithAvroSchemaRevisionsExample.java: googleapis/java-pubsub#1469

…33900) Add sample for pubsub_subscribe_avro_records_with_revisions. The design is based on SubscribeWithAvroSchemaRevisionsExample.java: googleapis/java-pubsub#1469

kamalaboulhosn added 3 commits January 23, 2023 10:19

samples: schema evolution
3c6897c

samples: schema evolution
7ea48d9

Merge branch 'googleapis:main' into master
3438da5

kamalaboulhosn requested review from a teamJanuary 23, 2023 16:48

product-auto-labelBot added the size: l Pull request size is large. label Jan 23, 2023

product-auto-labelBot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jan 23, 2023

blunderbuss-gcfBot assigned Sita04 Jan 23, 2023

kamalaboulhosn added 3 commits January 23, 2023 12:00

Format fixes
4e5c026

Merge branch 'master' ofhttps://github.com/kamalaboulhosn/java-pubsub
032a92f

Fix documentation for field.
8a81408

Sita04 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2023

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2023

gcf-owl-botBotand others added 4 commits January 26, 2023 16:28

🦉 Updates from OwlBot post-processor
90800ac
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Add back in working asserts
a88377c

Merge branch 'master' ofhttps://github.com/kamalaboulhosn/java-pubsub
6a741ea

Formatting fixes
9a07bbd

Sita04 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2023

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2023

🦉 Updates from OwlBot post-processor
df27d57
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

hongalex reviewed Jan 31, 2023
View reviewed changes

Comment threadsamples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java Outdated
Comment threadsamples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java Outdated

kamalaboulhosn added 6 commits February 14, 2023 11:35

Version/delete fixes
7d1c561

Merge branch 'master' ofhttps://github.com/kamalaboulhosn/java-pubsub
d917065

samples: schema evolution
646afa7

samples: schema evolution
e0cce5a

Format fixes
51deeb0

Fix documentation for field.
a53b564

Merge branch 'master' ofhttps://github.com/kamalaboulhosn/java-pubsub
7d15680

product-auto-labelBot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Feb 23, 2023

kamalaboulhosnand others added 2 commits February 23, 2023 17:47

Merge branch 'googleapis:main' into master
f5d8b39

product-auto-labelBot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Feb 23, 2023

kamalaboulhosnand others added 5 commits February 23, 2023 18:20

Minor fixes for comments
6195b1c

Merge branch 'master' ofhttps://github.com/kamalaboulhosn/java-pubsub
24cc817

Merge branch 'schema-evolution-examples' ofhttps://github.com/google…
37a35cb
…apis/java-pubsub into schema-evolution-examples

Merge branch 'schema-evolution-examples' into master
79b0514

hongalex reviewed Feb 27, 2023
View reviewed changes

Comment threadsamples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java Outdated

hongalex reviewed Feb 27, 2023
View reviewed changes

Comment threadsamples/snippets/src/main/java/pubsub/SubscribeWithAvroSchemaRevisionsExample.java Outdated

hongalex reviewed Feb 28, 2023
View reviewed changes

Comment threadsamples/snippets/src/test/java/pubsub/SchemaIT.java

kamalaboulhosn added 4 commits March 10, 2023 07:01

Fix rollback example
b1d2309

Formatting
3f74191

Formatting and wording fixes
8b1288a

Add new schemas to test directory
5057f17

kamalaboulhosn requested a review from hongalex March 10, 2023 14:34

kamalaboulhosn added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023

🦉 Updates from OwlBot post-processor
ba38121
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

acocuzzo approved these changes Mar 11, 2023
View reviewed changes

kamalaboulhosn merged commit a28803d into googleapis:mainMar 11, 2023

yash30201 mentioned this pull request May 18, 2023
feat(PubSub): Added Samples GoogleCloudPlatform/php-docs-samples#1845
Merged

quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this pull request Apr 30, 2026
chore(pubsub): Add sample for subscribe avro records with revisions
1285fe2
The design is based on SubscribeWithAvroSchemaRevisionsExample.java: googleapis/java-pubsub#1469

quartzmo mentioned this pull request Apr 30, 2026
chore(pubsub): Add sample for subscribe avro records with revisions googleapis/google-cloud-ruby#33900
Merged

torreypayne mentioned this pull request Jun 5, 2026
chore: Add pubsub rollback schema sample googleapis/google-cloud-ruby#34019
Merged

Navigation Menu

Uh oh!

samples: Schema evolution - #1469

samples: Schema evolution#1469
kamalaboulhosn merged 34 commits into
googleapis:mainfrom
kamalaboulhosn:master

kamalaboulhosn commented Jan 23, 2023

Uh oh!

snippet-botBot commented Jan 23, 2023•
edited
Loading

Uh oh!

Sita04 commented Jan 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acocuzzo left a comment

Uh oh!

acocuzzoMar 11, 2023

Uh oh!

acocuzzoMar 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kamalaboulhosn commented Jan 23, 2023

Uh oh!

snippet-botBot commented Jan 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sita04 commented Jan 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acocuzzo left a comment

Choose a reason for hiding this comment

Uh oh!

acocuzzoMar 11, 2023

Choose a reason for hiding this comment

Uh oh!

acocuzzoMar 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

snippet-botBot commented Jan 23, 2023•
edited
Loading