Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

feat: include thread name in traces - #3173

Merged
gcf-merge-on-green[bot] merged 5 commits into
mainfrom
trace-thread-name
Jul 3, 2024
Merged

feat: include thread name in traces#3173
gcf-merge-on-green[bot] merged 5 commits into
mainfrom
trace-thread-name

Conversation

@olavloite

Copy link
Copy Markdown
Collaborator

Include the name of the tread that is executing a statement in the traces that are generated, so it is easier to debug concurrency issues. Sometimes, it is not clear whether a statement is being executed by a background worker thread or the main thread.

Include the name of the tread that is executing a statement in the
traces that are generated, so it is easier to debug concurrency
issues. Sometimes, it is not clear whether a statement is being
executed by a background worker thread or the main thread.
@olavloite
olavloite requested review from a teamJune 24, 2024 10:05
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 24, 2024
@olavloiteolavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 3, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2024
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 92b1e07 into mainJul 3, 2024
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 3, 2024
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the trace-thread-name branch July 3, 2024 07:50
@release-pleaserelease-pleaseBot mentioned this pull request Jul 3, 2024
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Jul 3, 2024
Include the name of the tread that is executing a statement in the traces that are generated, so it is easier to debug concurrency issues. Sometimes, it is not clear whether a statement is being executed by a background worker thread or the main thread.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/java-spanner API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@rahul2393@yoshi-kokoro