Skip to content

feat: update V4 signature to pass conformance tests - #114

Merged
JesseLovelace merged 14 commits into
masterfrom
updatev4
Feb 5, 2020
Merged

feat: update V4 signature to pass conformance tests#114
JesseLovelace merged 14 commits into
masterfrom
updatev4

Conversation

@JesseLovelace

@JesseLovelaceJesseLovelace commented Feb 4, 2020

Copy link
Copy Markdown
Contributor

This updates the conformance tests and adds the consistency changes necessary to make them pass, as per #84 and #85

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2020
frankyn
frankyn suggested changes Feb 4, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, overall LGTM I have one question before approving.

Comment threadgoogle-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
HOST_NAME,
PATH_STYLE,
VIRTUAL_HOSTED_STYLE,
BUCKET_BOUND_HOST_NAME,

@frankynfrankynFeb 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesse, I want to confirm that HOST_NAME can't be in the same way as BUCKET_BOUND_HOST_NAME. Is this accurate?

@codecov

codecovBot commented Feb 5, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #114 into master will increase coverage by 0.42%.
The diff coverage is 84.61%.

Impacted file tree graph

@@ Coverage Diff @@## master #114 +/- ##
============================================
+ Coverage 63.3% 63.73% +0.42% - Complexity 528 539 +11 
============================================
Files 30 30 Lines 4720 4740 +20 Branches 450 455 +5 ============================================
+ Hits 2988 3021 +33 + Misses 1571 1564 -7 + Partials 161 155 -6
Impacted FilesCoverage ΔComplexity Δ
...n/java/com/google/cloud/storage/SignatureInfo.java81.5% <100%> (+0.81%)19 <0> (+2)⬆️
...ain/java/com/google/cloud/storage/StorageImpl.java78.72% <76.92%> (+1.91%)119 <3> (+9)⬆️
...rc/main/java/com/google/cloud/storage/Storage.java80.63% <90.9%> (+0.58%)0 <0> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044de39...148dfc4. Read the comment docs.

frankyn
frankyn approved these changes Feb 5, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesseLovelaceJesseLovelace changed the title Update V4 signature to pass conformance testsfeat: update V4 signature to pass conformance testsFeb 5, 2020
frankyn
frankyn approved these changes Feb 5, 2020
View reviewed changes

@frankynfrankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JesseLovelace
JesseLovelace merged commit c86276b into masterFeb 5, 2020
@JesseLovelace
JesseLovelace deleted the updatev4 branch February 5, 2020 20:21
@JesseLovelaceJesseLovelace mentioned this pull request Feb 5, 2020
Closed
1 task
@yoshi-automationyoshi-automation mentioned this pull request Feb 21, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@frankynfrankynfrankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JesseLovelace@frankyn@googlebot