feat: add object retention feature

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon

[JesseLovelace]

Adds the object retention feature and tests

[BenWhitehead]

I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?

[BenWhitehead]

If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketTest.java

Lines 123 to 124 in cf944ae

	try (TemporaryBuckettempB =
	TemporaryBucket.newBuilder().setBucketInfo(bucketInfo).setStorage(storage).build()) {

[frankyn]

What was the conclusion on detecting if a user set retention to null vs. it not being modified?

[JesseLovelace]

It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding

[frankyn]

Thanks for clarifying, is this value mutable once set?

[JesseLovelace]

Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes

No longer blocking, but tests can't pass yet so not approving

[JesseLovelace]

The current failure is just because the test project isn't allowlisted yet, it should be soon