Uh oh!
There was an error while loading. Please reload this page.
chore: Updating MPU implementation to work with the default host - #3376
Closed
ShreyasSinha wants to merge 19 commits into
Closed
chore: Updating MPU implementation to work with the default host#3376ShreyasSinha wants to merge 19 commits into
ShreyasSinha wants to merge 19 commits into
Conversation
ShreyasSinha
marked this pull request as ready for review
October 30, 2025 19:39
10 tasks
Uh oh!
There was an error while loading. Please reload this page.
…ided with StorageOptions.
ShreyasSinhaforce-pushed
the
mpu-feature-8
branch
from
October 31, 2025 11:28
4ba6b29 to
7fe33a5CompareBenWhitehead
approved these changes
Oct 31, 2025
BenWhitehead
left a comment
Collaborator
There was a problem hiding this comment.
ready for merge train
Update MultipartUploadHttpRequestManager to take crc32c nullability into consideration for all usages
If UTF-8 charset isn't available there is something busted in the jvm being used. Catch the exception and turn it into a StorageException so all usage doesn't need to handle UnsupportedEncodingException.
These are utilities we need to parsing http responses. Customers will receive the response object after our parsing is complete, and the response object has a builder for their testing needs.
…loadHttpRequestManagerTest.sendCreateMultipartUploadRequest_withCannedAcl
…dClientTest#testMultipartUpload_parallel The ~513MiB object can now be tested in ~30 seconds instead of 3 minutes
BenWhitehead
commented
Nov 3, 2025
Collaborator
merged to main in #3378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating MPU implementation to work with the default host provided with StorageOptions.
Refer: #3348