Skip to content

test: update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759) - #817

Merged
BenWhitehead merged 1 commit into
googleapis:masterfrom
BenWhitehead:backport-9a6619c
May 11, 2021
Merged

test: update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)#817
BenWhitehead merged 1 commit into
googleapis:masterfrom
BenWhitehead:backport-9a6619c

Conversation

@BenWhitehead

Copy link
Copy Markdown
Collaborator

Port of googleapis/google-cloud-go#3806

Fixes#755

cherry-pick from
9a6619c

@BenWhitehead
BenWhitehead requested a review from a teamMay 11, 2021 18:26
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2021
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/java-storage API. label May 11, 2021
@BenWhiteheadBenWhitehead added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 11, 2021

@tritonetritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would go with conventional commit type test to avoid having this in release notes.

@codecov

codecovBot commented May 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #817 (3a20a5d) into master (179cde9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #817 +/- ##
=========================================
Coverage 64.61% 64.61% - Complexity 625 634 +9 
=========================================
Files 32 32 Lines 5313 5313 Branches 520 519 -1 =========================================
Hits 3433 3433 Misses 1718 1718 Partials 162 162 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179cde9...3a20a5d. Read the comment docs.

@BenWhiteheadBenWhitehead changed the title fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)test: update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)May 11, 2021
@BenWhitehead
BenWhitehead merged commit 1a576ca into googleapis:masterMay 11, 2021
@BenWhitehead
BenWhitehead deleted the backport-9a6619c branch May 11, 2021 18:34
@BenWhitehead
BenWhitehead restored the backport-9a6619c branch May 11, 2021 18:49
@BenWhitehead
BenWhitehead deleted the backport-9a6619c branch May 11, 2021 19:02
gcf-merge-on-greenBot pushed a commit that referenced this pull request May 13, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.114.0](https://www.github.com/googleapis/java-storage/compare/v1.113.16...v1.114.0) (2021-05-13)
### Features
* Remove client side vaildation for lifecycle conditions ([#816](https://www.github.com/googleapis/java-storage/issues/816)) ([5ec84cc](https://www.github.com/googleapis/java-storage/commit/5ec84cc2935a4787dd14a207d27501878f5849d5))
### Bug Fixes
* **test:** update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication ([#759](https://www.github.com/googleapis/java-storage/issues/759)) ([#817](https://www.github.com/googleapis/java-storage/issues/817)) ([1a576ca](https://www.github.com/googleapis/java-storage/commit/1a576ca3945b51d7a678aa2414be91b3c6b2d55e))
### Dependencies
* update dependency com.google.api-client:google-api-client to v1.31.5 ([#820](https://www.github.com/googleapis/java-storage/issues/820)) ([9e1bc0b](https://www.github.com/googleapis/java-storage/commit/9e1bc0b42abdaab0b11d761ecdbb92f6116aacd2))
* update dependency com.google.api.grpc:grpc-google-cloud-kms-v1 to v0.88.3 ([#797](https://www.github.com/googleapis/java-storage/issues/797)) ([747e7e4](https://www.github.com/googleapis/java-storage/commit/747e7e463c028b9cf8a406b7536b1916c1d52c01))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#815](https://www.github.com/googleapis/java-storage/issues/815)) ([e210de9](https://www.github.com/googleapis/java-storage/commit/e210de93452243242be7d3d719d00da723632335))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the googleapis/java-storage API.cla: yesThis human has signed the Contributor License Agreement.kokoro:runAdd this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage.it.ITStorageTest: testDownloadPublicBlobWithoutAuthentication failed

2 participants

@BenWhitehead@tritone