Uh oh!
There was an error while loading. Please reload this page.
fix: Add bucket ownership verification to prevent bucket squatting in Model.upload() - #6574
Merged
Merged
Conversation
copybara-serviceBotforce-pushed
the
copybara_897201695
branch
8 times, most recently
from
April 14, 2026 16:17
8eb235e to
73a0528Compare… Model.upload() PiperOrigin-RevId: 899642927
copybara-serviceBotforce-pushed
the
copybara_897201695
branch
from
April 14, 2026 17:02
73a0528 to
9feda02Compareinstantraaamen added a commit
to instantraaamen/python-aiplatform
that referenced
this pull request
Apr 19, 2026
The staging bucket fix (googleapis#6574) added `_verify_bucket_ownership()` to prevent bucket squatting, but the pipeline artifacts bucket still uses a predictable name (`{project}-vertex-pipelines-{location}`) and does not verify ownership when the bucket already exists. This adds the same ownership check to `create_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Add bucket ownership verification to prevent bucket squatting in Model.upload()