Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: add operation name to x-goog-request-params - #133

Merged
busunkim96 merged 2 commits into
masterfrom
add-operation-name
Jan 25, 2021
Merged

fix: add operation name to x-goog-request-params#133
busunkim96 merged 2 commits into
masterfrom
add-operation-name

Conversation

@busunkim96

@busunkim96busunkim96 commented Jan 19, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Add the routing header x-goog-request-params to operations client requests. Some APIs require that the header be passed on all requests.

Fixesgoogleapis/gapic-generator-python#732

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2021
This was referenced Jan 19, 2021
Closed
Closed
software-dov
software-dov approved these changes Jan 25, 2021
View reviewed changes

@software-dovsoftware-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nitpicking.

Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2021
@busunkim96
busunkim96 merged commit 97cef4a into masterJan 25, 2021
@busunkim96
busunkim96 deleted the add-operation-name branch January 25, 2021 19:49
@busunkim96busunkim96 mentioned this pull request Jan 25, 2021
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request Feb 12, 2021
@busunkim96
fix: add operation name to x-goog-request-params in async client (#137)
7271b23
Pass the operation name in the `x-goog-request-params`header.
Same as #133 for the async operations client.
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-fensteralexander-fensterAwaiting requested review from alexander-fenster
3 more reviewers
@tseavertseavertseaver approved these changes
@software-dovsoftware-dovsoftware-dov approved these changes
@turbaszekturbaszekturbaszek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.kokoro:force-runAdd this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Routing headers are not passed to the operations client

4 participants

@busunkim96@tseaver@software-dov@turbaszek