Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: AsyncIO Integration [Part 2] - #28

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
lidizheng:aio-part-2
Jun 2, 2020
Merged

feat: AsyncIO Integration [Part 2]#28
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
lidizheng:aio-part-2

Conversation

@lidizheng

@lidizhenglidizheng commented May 18, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Children PR of #26.

This PR includes AsyncIO version of:

  • Polling future
  • Page iterator

The AsyncIO version of polling future still uses the same mechanism as the sync version. The AsyncIO polling future tries to update its own state whenever the application want to access information or perform actions.

For page iterator, it has similar interface design as sync version. But instead of fulfilling normal generator protocol, it is based on the async generator.

Related #23

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020
@lidizhenglidizheng changed the title AsyncIO Integration [Part 2]feat: AsyncIO Integration [Part 2]May 18, 2020
@lidizheng
lidizhengforce-pushed the aio-part-2 branch 2 times, most recently from 93a8cb8 to 41cf623CompareMay 18, 2020 21:54
@lidizheng
lidizheng marked this pull request as ready for review May 18, 2020 22:11
@lidizhenglidizheng mentioned this pull request May 18, 2020
Merged
busunkim96
busunkim96 reviewed May 27, 2020
View reviewed changes
Comment threaddocs/operation.rst Outdated
Comment threadgoogle/api_core/operation_async.py Outdated
Comment threadgoogle/api_core/operation_async.py Outdated
Comment threadgoogle/api_core/future/async_future.py
lidizheng
lidizheng commented May 27, 2020
View reviewed changes

@lidizhenglidizheng left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 Thanks for reviewing! PTALA.

Comment threaddocs/operation.rst Outdated
Comment threadgoogle/api_core/future/async_future.py
Comment threadgoogle/api_core/operation_async.py Outdated
Comment threadgoogle/api_core/operation_async.py Outdated
@lidizheng
feat: Second batch of AsyncIO integration
47eaeea
* Polling future
* Page iterator
* With unit tests & docs
@busunkim96busunkim96 mentioned this pull request May 27, 2020
Merged
busunkim96
busunkim96 approved these changes May 27, 2020
View reviewed changes
Comment threaddocs/operation.rst Outdated
@lidizheng@busunkim96
Update docs/operation.rst
e7596f4
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
software-dov
software-dov approved these changes Jun 2, 2020
View reviewed changes

@software-dovsoftware-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests look good, just one minor commentary nit.

Comment threadgoogle/api_core/page_iterator_async.py Outdated
@lidizheng

lidizheng commented Jun 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing 👍

@busunkim96busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 2, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit dd9b2f3 into googleapis:masterJun 2, 2020
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jun 4, 2020
@release-please
chore: release 1.18.0 (#33)
33ab7fa
🤖 I have created a release \*beep\* \*boop\* ---
## [1.18.0](https://www.github.com/googleapis/python-api-core/compare/v1.17.0...v1.18.0) (2020-06-04)
### Features
* [CBT-6 helper] Exposing Retry._deadline as a property ([#20](https://www.github.com/googleapis/python-api-core/issues/20)) ([7be1e59](https://www.github.com/googleapis/python-api-core/commit/7be1e59e9d75c112f346d2b76dce3dd60e3584a1))
* add client_encryped_cert_source to ClientOptions ([#31](https://www.github.com/googleapis/python-api-core/issues/31)) ([e4eaec0](https://www.github.com/googleapis/python-api-core/commit/e4eaec0ff255114138d3715280f86d34d861a6fa))
* AsyncIO Integration [Part 2] ([#28](https://www.github.com/googleapis/python-api-core/issues/28)) ([dd9b2f3](https://www.github.com/googleapis/python-api-core/commit/dd9b2f38a70e85952cc05552ec8070cdf29ddbb4)), closes [#23](https://www.github.com/googleapis/python-api-core/issues/23)
* First batch of AIO integration ([#26](https://www.github.com/googleapis/python-api-core/issues/26)) ([a82f289](https://www.github.com/googleapis/python-api-core/commit/a82f2892b8f219b82e120e6ed9f4070869c28be7))
* third batch of AsyncIO integration ([#29](https://www.github.com/googleapis/python-api-core/issues/29)) ([7d8d580](https://www.github.com/googleapis/python-api-core/commit/7d8d58075a92e93662747d36a2d55b5e9f0943e1))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@busunkim96busunkim96 mentioned this pull request Jun 17, 2020
Closed
4 tasks
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@software-dovsoftware-dovsoftware-dov approved these changes
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lidizheng@software-dov@busunkim96@googlebot