Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: Improve transcoding error message in v1 branch - #445

Merged
vam-google merged 1 commit into
v1from
sync-v1
Sep 14, 2022
Merged

fix: Improve transcoding error message in v1 branch#445
vam-google merged 1 commit into
v1from
sync-v1

Conversation

@parthea

Copy link
Copy Markdown
Contributor

Port changes from #442 into v1 branch

* fix: Improve transcodding error message
This fixes#441 and #440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.
* reformat code with black
@parthea
parthea requested review from a teamSeptember 14, 2022 15:02
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Sep 14, 2022

@vam-googlevam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google
vam-google merged commit d0352ca into v1Sep 14, 2022
@vam-google
vam-google deleted the sync-v1 branch September 14, 2022 18:21
@release-pleaserelease-pleaseBot mentioned this pull request Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea@vam-google