Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: Add grpc Compression argument to channels and methods - #451

Merged
parthea merged 31 commits into
googleapis:mainfrom
acocuzzo:add-compression
Sep 7, 2023
Merged

feat: Add grpc Compression argument to channels and methods#451
parthea merged 31 commits into
googleapis:mainfrom
acocuzzo:add-compression

Conversation

@acocuzzo

@acocuzzoacocuzzo commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

The grpc library allows compression to be set the channel as well as call level
Fixes#450 🦕

@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Sep 21, 2022
@acocuzzoacocuzzo changed the title (feat): Add grpc Compression argument to channels and methodsfeat: Add grpc Compression argument to channels and methodsSep 21, 2022
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 17, 2023
@acocuzzo
acocuzzo marked this pull request as ready for review May 6, 2023 23:48
@acocuzzo
acocuzzo requested review from a teamMay 6, 2023 23:48
meredithslota
meredithslota reviewed May 8, 2023
View reviewed changes
Comment threadgoogle/api_core/gapic_v1/method.py Outdated
@partheaparthea self-assigned this Sep 1, 2023
parthea
parthea approved these changes Sep 1, 2023
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one observation. @acocuzzo PTAL

Comment threadgoogle/api_core/grpc_helpers.py Outdated
@partheaparthea assigned acocuzzo and unassigned partheaSep 1, 2023
parthea
parthea reviewed Sep 2, 2023
View reviewed changes
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_async_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_async_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_async_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_async_client.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_client.py Outdated
acocuzzoand others added 8 commits September 2, 2023 16:27
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_client.py
b1332d8
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_client.py
c661ecc
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_client.py
8ffa4da
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_async_client.py
26438ba
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_async_client.py
21371b0
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_async_client.py
8aeeffd
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_async_client.py
6becbeb
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo@parthea
Update google/api_core/operations_v1/operations_client.py
0aa0249
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@parthea
parthea merged commit bdebd63 into googleapis:mainSep 7, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Sep 7, 2023
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meredithslotameredithslotaAwaiting requested review from meredithslota
1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@acocuzzoacocuzzo

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow passing grpc.Compression to grpc calls and channels

3 participants

@acocuzzo@parthea@meredithslota