Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add support for Python 3.11 - #466

Merged
parthea merged 9 commits into
googleapis:mainfrom
ziegenberg:add-python-3-11-support
Nov 10, 2022
Merged

feat: add support for Python 3.11#466
parthea merged 9 commits into
googleapis:mainfrom
ziegenberg:add-python-3-11-support

Conversation

@ziegenberg

@ziegenbergziegenberg commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#467 🦕

@ziegenberg
ziegenberg requested review from a teamNovember 8, 2022 22:47
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Nov 8, 2022
@ziegenberg
ziegenbergforce-pushed the add-python-3-11-support branch from acb6f92 to 6275bb5CompareNovember 8, 2022 22:48
@dandhlee

Copy link
Copy Markdown
Contributor

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

@ziegenberg

Copy link
Copy Markdown
ContributorAuthor

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

That's right; I do work with Google. I will open an issue.

I followed #284 when creating this PR, which also did not have an accompanying issue.

@ziegenberg
ziegenbergforce-pushed the add-python-3-11-support branch from 6275bb5 to 6556f1bCompareNovember 9, 2022 22:37
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
ziegenbergforce-pushed the add-python-3-11-support branch from 6556f1b to 34b87dcCompareNovember 9, 2022 22:38
@ziegenberg

Copy link
Copy Markdown
ContributorAuthor

The python -m py.test call had to be changed to python -m pytest, otherwise it would always fail with:

Error while finding module specification for 'py.test' (ModuleNotFoundError: __path__ attribute not found on 'py' while trying to find 'py.test')

@ziegenberg

Copy link
Copy Markdown
ContributorAuthor

If it's okay with you, I would rebase my PR onto the current main. That should solve the Commit message did not follow Conventional Commits error.

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the minimum version of grpcio is 1.49.1 for python 3.11. I've updated the setup.py to reflect that.

@partheaparthea changed the title add support for Python 3.11feat: add support for Python 3.11Nov 10, 2022
@parthea
parthea merged commit ff379e3 into googleapis:mainNov 10, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Nov 10, 2022
@parthea

Copy link
Copy Markdown
Contributor

Thanks @ziegenberg!

@ziegenberg
ziegenberg deleted the add-python-3-11-support branch November 10, 2022 16:42
This was referenced May 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for Python 3.11

3 participants

@ziegenberg@dandhlee@parthea