Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix(dependencies): increase protobuf version - #49

Merged
busunkim96 merged 1 commit into
masterfrom
busunkim96-patch-1
Jun 16, 2020
Merged

fix(dependencies): increase protobuf version#49
busunkim96 merged 1 commit into
masterfrom
busunkim96-patch-1

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Increase protobuf version to 3.12.0 for _internal_create_key.

See protocolbuffers/protobuf@b99994d for the commit where this was added.

Fixes#48 🦕

Increase protobuf version to 3.12.0 for `_internal_create_key`. Closes#48
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2020

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

With protobuf==3.12.0, the following import does not result in an error anymore, unlike in some older protobuf versions:

fromgoogle.cloud.pubsub_v1.typesimportPushConfig

@busunkim96
busunkim96 merged commit 1ba6095 into masterJun 16, 2020
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jun 16, 2020
@tseaver
tseaver deleted the busunkim96-patch-1 branch December 8, 2020 18:12
This was referenced May 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating the pubsub client breaks because it needs a newer version of protobuf

3 participants

@busunkim96@plamut@googlebot