Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add caching to GapicCallable - #666

Merged
parthea merged 35 commits into
mainfrom
optimize_gapic_callable
Oct 21, 2024
Merged

feat: add caching to GapicCallable#666
parthea merged 35 commits into
mainfrom
optimize_gapic_callable

Conversation

@parthea

@partheaparthea commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Opening a new PR to restore the features in #527 which were reverted in #665 due to #660

cc @daniel-sanche

BEGIN_COMMIT_OVERRIDE
chore: add caching to GapicCallable
END_COMMIT_OVERRIDE

@parthea
parthea requested review from a teamJune 4, 2024 14:29
@partheaparthea changed the title Optimize gapic callablefeat: add caching to GapicCallableJun 4, 2024
@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 4, 2024
@parthea
parthea marked this pull request as draft June 4, 2024 14:32

@daniel-sanchedaniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche

Copy link
Copy Markdown
Contributor

@parthea Just changed the metadata type to a list, and added types to a docstring

@partheaparthea assigned parthea and unassigned daniel-sancheOct 21, 2024
@partheaparthea added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 21, 2024
@parthea

parthea commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Waiting for test results in cl/688135988 Tests passed

@partheaparthea removed status: investigating The issue is under investigation, which is determined to be non-trivial. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2024
@parthea
parthea marked this pull request as ready for review October 21, 2024 15:10
@parthea
parthea merged commit 1695119 into mainOct 21, 2024
@parthea
parthea deleted the optimize_gapic_callable branch October 21, 2024 15:11
@release-pleaserelease-pleaseBot mentioned this pull request Oct 21, 2024
parthea added a commit that referenced this pull request Oct 23, 2024
parthea added a commit that referenced this pull request Oct 23, 2024
@partheaparthea added the release-please:force-run To run release-please label Oct 23, 2024
@release-pleaserelease-pleaseBot removed the release-please:force-run To run release-please label Oct 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@daniel-sanche@vchudnov-g