Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: remove use of old external mock - #676

Closed
a-detiste wants to merge 2 commits into
googleapis:mainfrom
a-detiste:main
Closed

fix: remove use of old external mock#676
a-detiste wants to merge 2 commits into
googleapis:mainfrom
a-detiste:main

Conversation

@a-detiste

Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue: there were various attempts before that got stuck by lack of CLA
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@a-detiste
a-detiste requested review from a teamJuly 6, 2024 21:50
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jul 6, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Jul 6, 2024
@partheaparthea changed the title new attempt at remove use of old external mockfix: remove use of old external mockJul 29, 2024
@a-detiste

Copy link
Copy Markdown
Author

This looks a tad too early as Py3.7 is still currently supported

@partheaparthea mentioned this pull request Oct 9, 2024
4 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@a-detiste@parthea