Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add support for asynchronous rest streaming - #686

Merged
ohmayr merged 30 commits into
mainfrom
add-support-for-async-rest-streaming
Sep 18, 2024
Merged

feat: add support for asynchronous rest streaming#686
ohmayr merged 30 commits into
mainfrom
add-support-for-async-rest-streaming

Conversation

@ohmayr

@ohmayrohmayr commented Aug 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds support for asynchronous rest streaming in core to be leveraged in GAPICs.

The changes in this PR can be tested against: googleapis/google-auth-library-python#1577.

@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Aug 11, 2024
@ohmayr
ohmayr marked this pull request as ready for review August 20, 2024 15:45
@ohmayr
ohmayr requested review from a teamAugust 20, 2024 15:45
@ohmayr
ohmayr changed the base branch from async-rest-support-in-core to mainAugust 22, 2024 17:20
vchudnov-g
vchudnov-g reviewed Aug 22, 2024
View reviewed changes

@vchudnov-gvchudnov-g left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you "fork" the file you're refactoring from into the file you're refacotring "to", adapting the dirctions in https://devblogs.microsoft.com/oldnewthing/20190919-00/?p=102904 ? It will make it easier to review, and preserve git history for the future.

@ohmayr
ohmayrforce-pushed the add-support-for-async-rest-streaming branch from 29d662b to fdeb437CompareAugust 23, 2024 15:26
vchudnov-g
vchudnov-g reviewed Aug 23, 2024
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment threadgoogle/api_core/_rest_streaming_base.py Outdated
Comment threadgoogle/api_core/_rest_streaming_base.py Outdated
Comment threadgoogle/api_core/_rest_streaming_base.py Outdated
Comment threadgoogle/api_core/rest_streaming.py
Comment threadgoogle/api_core/rest_streaming_async.py Outdated
Comment threadtests/unit/test_rest_streaming_async.py
Comment threadtests/unit/test_rest_streaming_async.py Outdated
Comment threadtests/unit/test_rest_streaming_async.py Outdated
Comment threadtests/unit/test_rest_streaming_async.py
Comment threadtests/unit/test_rest_streaming_async.py
@ohmayrohmayr mentioned this pull request Jan 12, 2026
Open
@ohmayr

ohmayr commented Aug 24, 2024

Copy link
Copy Markdown
ContributorAuthor

I will move test_rest_streaming_async.py from tests/unit to tests/asyncio which is where we have our async tests once we do not have any other open concerns.

vchudnov-g
vchudnov-g approved these changes Aug 26, 2024
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments, but no blockers. Thanks for doing this!

Comment threadgoogle/api_core/rest_streaming.py
Comment threadgoogle/api_core/_rest_streaming_base.py
Comment threadgoogle/api_core/rest_streaming.py Outdated
ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
ValueError:
- If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
- If `response` is not an instance of `requests.Response`.

@vchudnov-gvchudnov-gAug 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this exception raised? Line 46 will succeed with a matching method of any class, right?

@ohmayrohmayrSep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to not raise an error for this. We've added the relevant type hints. Cleaned up the docstring.

Comment threadtests/unit/test_rest_streaming_async.py
Comment threadtests/helpers.py Outdated
@ohmayrohmayr added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
ohmayr
ohmayr commented Sep 2, 2024
View reviewed changes
Comment threadgoogle/api_core/rest_streaming_async.py Outdated
@ohmayrohmayr removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 18, 2024
@ohmayr
ohmayr merged commit 1b7bb6d into mainSep 18, 2024
@ohmayr
ohmayr deleted the add-support-for-async-rest-streaming branch September 18, 2024 15:36
@release-pleaserelease-pleaseBot mentioned this pull request Sep 18, 2024
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@vchudnov-gvchudnov-gvchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vchudnov-gvchudnov-g

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ohmayr@vchudnov-g