Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: migrate to pyproject.toml - #736

Merged
parthea merged 20 commits into
googleapis:mainfrom
rinarakaki:pyproject
Oct 28, 2024
Merged

feat: migrate to pyproject.toml#736
parthea merged 20 commits into
googleapis:mainfrom
rinarakaki:pyproject

Conversation

@rinarakaki

@rinarakakirinarakaki commented Oct 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Tracking issue googleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki
rinarakaki requested review from a teamOctober 15, 2024 03:47
@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Oct 15, 2024
This was referenced Oct 15, 2024
Closed
Closed
Closed
@rinarakakirinarakaki changed the title feature: migrate to pyproject.tomlfeat: migrate to pyproject.tomlOct 16, 2024
@rinarakakirinarakaki mentioned this pull request Oct 16, 2024
Closed
15 tasks
@partheaparthea self-assigned this Oct 19, 2024
parthea
parthea approved these changes Oct 19, 2024
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rinarakaki!

Comment threadpyproject.toml
@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2024
@parthea

parthea commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

Adding do not merge until #729 is merged to avoid delaying the Python 3.13 release.

parthea
parthea reviewed Oct 19, 2024
View reviewed changes
Comment threadpyproject.toml Outdated
@partheaparthea removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. process: review requested labels Oct 28, 2024
@parthea
parthea merged commit 159e9a4 into googleapis:mainOct 28, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Oct 28, 2024
Merged
@rinarakaki
rinarakaki deleted the pyproject branch October 28, 2024 16:15
@partheaparthea mentioned this pull request Oct 28, 2024
Closed
@rinarakaki

rinarakaki commented Oct 28, 2024

Copy link
Copy Markdown
ContributorAuthor

@parthea thanks for the review and the merge!

This was referenced May 30, 2025
Closed
Closed
@vchudnov-gvchudnov-g mentioned this pull request Dec 8, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@partheapartheaparthea approved these changes
@BenRKarlBenRKarlBenRKarl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rinarakaki@parthea@BenRKarl@vchudnov-g