Uh oh!
There was an error while loading. Please reload this page.
fix: memory leak in bidi classes - #770
Conversation
| _LOGGER.warning("Background thread did not exit.") | ||
| self._thread = None | ||
| self._on_response = None |
There was a problem hiding this comment.
This assumes you can't restart an instance after it has been stopped. The test cases and docstrings point to that being the case, but it's not completely clear
There was a problem hiding this comment.
I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
| _LOGGER.warning("Background thread did not exit.") | ||
| self._thread = None | ||
| self._on_response = None |
There was a problem hiding this comment.
I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
parthea
commented
Jan 22, 2025
Thanks @daniel-sanche ! |
Fixes#769