Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback - #821

Merged
abbrowne126 merged 11 commits into
mainfrom
fix-background-consumer-error-closures
May 30, 2025
Merged

fix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback#821
abbrowne126 merged 11 commits into
mainfrom
fix-background-consumer-error-closures

Conversation

@abbrowne126

@abbrowne126abbrowne126 commented May 23, 2025•
edited by parthea
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

BEGIN_COMMIT_OVERRIDE
fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback
END_COMMIT_OVERRIDE

Fixes#820

@abbrowne126
abbrowne126 requested review from a teamMay 23, 2025 16:22
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label May 23, 2025
@abbrowne126
abbrowne126 marked this pull request as draft May 23, 2025 16:24
@abbrowne126
abbrowne126 marked this pull request as ready for review May 23, 2025 16:45
@abbrowne126

abbrowne126 commented May 29, 2025

Copy link
Copy Markdown
ContributorAuthor

@parthea , can you please take a look at this pull request?

This was referenced May 29, 2025
Closed
Closed
@abbrowne126abbrowne126 changed the title fix: add stop() call to BackgroundConsumer failures due to exceptionsfix: Allow BackgroundConsumer To Raise Exceptions To Caller With Non-Default Constructor OptionMay 30, 2025
@abbrowne126abbrowne126 changed the title fix: Allow BackgroundConsumer To Raise Exceptions To Caller With Non-Default Constructor Optionfix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Non-Default Constructor OptionMay 30, 2025
@abbrowne126abbrowne126 changed the title fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Non-Default Constructor Optionfix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional CallbackMay 30, 2025
parthea
parthea previously approved these changes May 30, 2025
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadgoogle/api_core/bidi.py Outdated
Comment threadtests/unit/test_bidi.py Outdated
@abbrowne126@parthea
Update tests/unit/test_bidi.py
7fc87c0
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@abbrowne126

abbrowne126 commented May 30, 2025

Copy link
Copy Markdown
ContributorAuthor

@parthea updated the WARNING to a NOTE but that caused the approval to expire - could you reapprove?

@abbrowne126
abbrowne126 merged commit 3206c01 into mainMay 30, 2025
@abbrowne126
abbrowne126 deleted the fix-background-consumer-error-closures branch May 30, 2025 19:36
@release-pleaserelease-pleaseBot mentioned this pull request May 30, 2025
Closed
@partheaparthea added release-please:force-run To run release-please and removed release-please:force-run To run release-please labels May 30, 2025
@release-pleaserelease-pleaseBot removed the release-please:force-run To run release-please label May 30, 2025
@partheaparthea added the release-please:force-run To run release-please label May 30, 2025
@release-pleaserelease-pleaseBot removed the release-please:force-run To run release-please label May 30, 2025
@partheaparthea changed the title fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callbackfix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional CallbackMay 30, 2025
@partheaparthea added the release-please:force-run To run release-please label May 30, 2025
@release-pleaserelease-pleaseBot removed the release-please:force-run To run release-please label May 30, 2025
@partheaparthea added the release-please:force-run To run release-please label Jun 2, 2025
@release-pleaserelease-pleaseBot removed the release-please:force-run To run release-please label Jun 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bidi BackgroundConsumer not Properly Notifying Caller on Fatal Processing Exceptions

2 participants

@abbrowne126@parthea