Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: support for async bidi streaming apis - #836

Merged
vchudnov-g merged 31 commits into
googleapis:mainfrom
chandra-siri:feat/834-bidi-async-support
Oct 14, 2025
Merged

feat: support for async bidi streaming apis#836
vchudnov-g merged 31 commits into
googleapis:mainfrom
chandra-siri:feat/834-bidi-async-support

Conversation

@chandra-siri

@chandra-sirichandra-siri commented Aug 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

feat: support for async bidi streaming apis

Further details can be found here

Fixes#834

@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Aug 14, 2025
@chandra-siri
chandra-siri marked this pull request as ready for review August 30, 2025 17:13
@chandra-siri
chandra-siri requested review from a teamAugust 30, 2025 17:13
ohmayr
ohmayr reviewed Sep 4, 2025
View reviewed changes
Comment threadgoogle/api_core/bidi_async.py Outdated
Comment threadgoogle/api_core/bidi.py
Comment threadgoogle/api_core/bidi.py
Comment threadgoogle/api_core/bidi_async.py Outdated
Comment threadgoogle/api_core/bidi_async.py Outdated
Comment threadgoogle/api_core/bidi_async.py Outdated
Comment threadgoogle/api_core/bidi_base.py Outdated
Comment threadgoogle/api_core/bidi_base.py Outdated
Comment threadgoogle/api_core/bidi_async.py
Comment threadgoogle/api_core/bidi_async.py
chandra-siri added a commit to chandra-siri/python-storage that referenced this pull request Sep 17, 2025
@chandra-siri
Add async bidiRpc files in python-storage
32168a6
these files will be removed once googleapis/python-api-core#836
gets submitted
@chandra-sirichandra-siri mentioned this pull request Sep 17, 2025
Merged
chandra-siri added a commit to googleapis/python-storage that referenced this pull request Sep 18, 2025
@chandra-siri
feat: Add async bidiRpc files in python-storage (#1545)
8b988ad
* Add async bidiRpc files in python-storage
these files will be removed once googleapis/python-api-core#836
gets submitted
* fix import path for bidi_base
@chandra-siri

chandra-siri commented Oct 1, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks good. I have some small comments, and a bunch of nits. I'll TAL at the test next week.

@vchudnov-g Addressed your comments. PTAL

vchudnov-g
vchudnov-g reviewed Oct 4, 2025
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We're almost there. Just some minor comments, and I want to ping @daniel-sanche again in case he has any comments.

Comment threadgoogle/api_core/bidi.py Outdated
Comment threadgoogle/api_core/bidi_async.py

request_generator.call = call

if hasattr(call, "_wrapped"): # pragma: NO COVER

@vchudnov-gvchudnov-gOct 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have an issue. You could create one, but at least copy the text: # TODO: api_core should expose the future interface for wrapped callables as well.

Comment threadgoogle/api_core/bidi_async.py

request_generator.call = call

if hasattr(call, "_wrapped"): # pragma: NO COVER

@vchudnov-gvchudnov-gOct 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue number (you could create one), but let's at least include the text: # TODO: api_core should expose the future interface for wrapped callables as well.

Comment threadgoogle/api_core/bidi_base.py
Comment threadtests/asyncio/test_bidi_async.py
Comment threadtests/asyncio/test_bidi_async.py Outdated
Comment threadtests/asyncio/test_bidi_async.py Outdated
Comment threadtests/asyncio/test_bidi_async.py Outdated
daniel-sanche
daniel-sanche reviewed Oct 6, 2025
View reviewed changes

@daniel-sanchedaniel-sanche left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small comments, but nothing that needs to be blocking

Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

Comment threadgoogle/api_core/bidi_base.py Outdated
Comment threadgoogle/api_core/bidi_base.py
Comment threadgoogle/api_core/bidi_base.py Outdated
Comment threadgoogle/api_core/bidi_base.py
daniel-sanche
daniel-sanche reviewed Oct 6, 2025
View reviewed changes
Comment threadgoogle/api_core/bidi_async.py
@chandra-siri

chandra-siri commented Oct 8, 2025

Copy link
Copy Markdown
ContributorAuthor

I left a few small comments, but nothing that needs to be blocking

Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

Hi @daniel-sanche , I've addressed your comments, left one open. Feel free to resolve it sounds good to you.

daniel-sanche
daniel-sanche reviewed Oct 8, 2025
View reviewed changes
Comment threadgoogle/api_core/bidi_async.py Outdated
daniel-sanche
daniel-sanche previously approved these changes Oct 8, 2025
View reviewed changes

@daniel-sanchedaniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a few nits open, but LGTM

@chandra-siri

chandra-siri commented Oct 9, 2025

Copy link
Copy Markdown
ContributorAuthor

still a few nits open, but LGTM

Addressed them.

@chandra-siri

chandra-siri commented Oct 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks good. We're almost there. Just some minor comments, and I want to ping @daniel-sanche again in case he has any comments.

Hi @vchudnov-g Addressed yours and Daniel's comments/suggestions. PTAL

vchudnov-g
vchudnov-g approved these changes Oct 10, 2025
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I left some very minor follow-up comments—nothing blocking.

Thanks for your dedication to this PR and patience working with us on understanding it and making it really solid!

@chandra-siri

chandra-siri commented Oct 11, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Looks great. I left some very minor follow-up comments—nothing blocking.

Addressed them.

Thanks for your dedication to this PR and patience working with us on understanding it and making it really solid!

Thanks @vchudnov-g

1 more help - can you please merge the PR ? (looks like I don't have the sufficient permissions)

@vchudnov-g
vchudnov-g merged commit 9530548 into googleapis:mainOct 14, 2025
45 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Oct 14, 2025
Merged
@chandra-siri
chandra-siri deleted the feat/834-bidi-async-support branch October 29, 2025 16:12
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ohmayrohmayrAwaiting requested review from ohmayr
2 more reviewers
@daniel-sanchedaniel-sanchedaniel-sanche approved these changes
@vchudnov-gvchudnov-gvchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vchudnov-gvchudnov-g

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need an async version of Bidi.py

4 participants

@chandra-siri@vchudnov-g@daniel-sanche@ohmayr