Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

chore: bump minimum version of protobuf to 4.25.8 - #839

Closed
ohmayr wants to merge 14 commits into
mainfrom
bump-protobuf-version
Closed

chore: bump minimum version of protobuf to 4.25.8#839
ohmayr wants to merge 14 commits into
mainfrom
bump-protobuf-version

Conversation

@ohmayr

@ohmayrohmayr commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

This PR bumps the minimum version of Protobuf to 4.25.8 to address the security vulnerability in Protobuf < 4.x.

This means that we're also removing dependency on grpc_gcp and grpcio_gcp which are needed for Protobuf < 4.x.

This PR also drops support for Python 3.7 since it is not supported by Protobuf 4.25.8.

Note: Bumping the major version could introduce diamond dependency, and we don't expect users to be impacted because grpcio-gcp is only supported in protobuf 3.x and users of protobuf 3.x would not be able to install the latest version of the library.

@ohmayr
ohmayr requested review from a teamSeptember 16, 2025 21:31
@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Sep 16, 2025
@ohmayrohmayr changed the title chore: bump minimum version of protobuf tochore: bump minimum version of protobuf to 4.25.8Sep 16, 2025
@ohmayr
ohmayr marked this pull request as draft September 17, 2025 00:06
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 17, 2025
@ohmayr
ohmayr marked this pull request as ready for review September 17, 2025 21:19
@ohmayr
ohmayrforce-pushed the bump-protobuf-version branch from 87faed2 to c625a66CompareSeptember 17, 2025 21:44
@vchudnov-g

Copy link
Copy Markdown
Contributor

Do not merge yet. We want to merge and release #832 before we increase the minimum versions of Python and of protobuf.

@vchudnov-gvchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 22, 2025
@parthea

Copy link
Copy Markdown
Contributor

Switching to draft state as there are conflicts

@parthea
parthea marked this pull request as draft January 12, 2026 15:25
@partheaparthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2026
@vchudnov-gvchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 4, 2026
@vchudnov-g

Copy link
Copy Markdown
Contributor

This PR should be superseded by #877, which is WIP at the moment.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do not mergeIndicates a pull request not ready for merge, due to either quality or timing.size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr@vchudnov-g@parthea