Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
chore(librarian): clean up owlbot files and pin image sha - #861
Merged
Conversation
ohmayr
previously approved these changes
Nov 11, 2025
vchudnov-g
commented
Nov 12, 2025
Contributor
I am implementing similar fixes to additional tests. I will continue tomorrow. |
| with pytest.warns( | ||
| DeprecationWarning, | ||
| match="argument is deprecated because of a potential security risk", | ||
| ): |
Contributor
There was a problem hiding this comment.
Do you think we could extract these lines, so it doesn't need to be copy/pasted in some many places?
I'm imagining something like:
assert_deprecation_warning = functools.partial(
pytest.warns, DeprecationWarning, match="argument is deprecated because of a potential security risk"
)
with assert_deprecation_warning():
...
gkevinzheng
approved these changes
Nov 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional clean up following #856