Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

feat!: move to microgenerator - #58

Merged
arithmetic1728 merged 9 commits into
masterfrom
sijun
Aug 5, 2020
Merged

feat!: move to microgenerator#58
arithmetic1728 merged 9 commits into
masterfrom
sijun

Conversation

@arithmetic1728

@arithmetic1728arithmetic1728 commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
busunkim96
busunkim96 reviewed Jul 30, 2020
View reviewed changes
Comment threadsynth.py
Comment threadsynth.py
busunkim96
busunkim96 approved these changes Jul 30, 2020
View reviewed changes

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please hold on merging until the samples have been incorporated.

@arithmetic1728

arithmetic1728 commented Jul 30, 2020

Copy link
Copy Markdown
ContributorAuthor

LGTM, but please hold on merging until the samples have been incorporated.

sure

@arithmetic1728
arithmetic1728 requested a review from a team as a code ownerAugust 5, 2020 07:12
@arithmetic1728

arithmetic1728 commented Aug 5, 2020

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 I completed migrating the samples, please take another look. Let's release 1.4.0 first (#61) for the last 1.x release. I already updated the last version supporting python 2.7 to 1.4.0 in README.rst, so we can merge this PR after that.

@arithmetic1728
arithmetic1728 merged commit 3219b64 into masterAug 5, 2020
@arithmetic1728
arithmetic1728 deleted the sijun branch August 5, 2020 21:28
@release-pleaserelease-pleaseBot mentioned this pull request Aug 5, 2020
Merged
@busunkim96busunkim96 mentioned this pull request Aug 6, 2020
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arithmetic1728@busunkim96