Skip to content
This repository was archived by the owner on May 16, 2026. It is now read-only.

fix: remove setup.cfg configuration for creating universal wheels - #1175

Merged
chalmerlowe merged 1 commit into
mainfrom
parthea-patch-2
Mar 14, 2025
Merged

fix: remove setup.cfg configuration for creating universal wheels#1175
chalmerlowe merged 1 commit into
mainfrom
parthea-patch-2

Conversation

@parthea

@partheaparthea commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

setup.cfg contains a setting to create a Universal Wheel which is only needed if libraries support both Python 2 and Python 3. This library only supports Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

See similar PR googleapis/google-cloud-python#13659 which includes this stack trace

 running bdist_wheel
/tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
!!
********************************************************************************
With Python 2.7 end-of-life, support for building universal wheels
(i.e., wheels that support both Python 2 and Python 3)
is being obviated.
Please discontinue using this option, or if you still need it,
file an issue with pypa/setuptools describing your use case.
By 2025-Aug-30, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
********************************************************************************
!!

@parthea
parthea requested review from a team and leahecoleMarch 14, 2025 13:02
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Mar 14, 2025
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Mar 14, 2025

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowechalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2025
@chalmerlowe
chalmerlowe merged commit dc394ac into mainMar 14, 2025
@chalmerlowe
chalmerlowe deleted the parthea-patch-2 branch March 14, 2025 19:18
@release-pleaserelease-pleaseBot mentioned this pull request Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API.automergeMerge the pull request once unit tests and other checks pass.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@chalmerlowe@chelsea-lin