Skip to content
This repository was archived by the owner on May 16, 2026. It is now read-only.

feat: add support for Python 3.10 - #381

Merged
tswast merged 2 commits into
googleapis:mainfrom
aucampia:iwana-20211221T1332-py310
Dec 30, 2021
Merged

feat: add support for Python 3.10#381
tswast merged 2 commits into
googleapis:mainfrom
aucampia:iwana-20211221T1332-py310

Conversation

@aucampia

@aucampiaaucampia commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#374 🦕

NOTE: system test fail for alembic, but that is the same as is happening on main branch, see #382 and #373

@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Dec 21, 2021
@aucampia
aucampia marked this pull request as ready for review December 21, 2021 13:57
@aucampia
aucampia requested a review from a team as a code ownerDecember 21, 2021 13:57
@aucampia
aucampia requested review from a team and dinagravesDecember 21, 2021 13:57
@aucampiaaucampia changed the title Enable support for 3.10Enable support for 3.10 [DRAFT]Dec 21, 2021
@aucampiaaucampia changed the title Enable support for 3.10 [DRAFT]Enable support for 3.10Dec 21, 2021

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the patch!

Comment threaddocs/conf.py Outdated
Comment threadnoxfile.py Outdated
Comment threadnoxfile.py Outdated
Comment threadowlbot.py Outdated
Comment threadowlbot.py Outdated
Comment threadowlbot.py
Comment threadsamples/snippets/requirements.in Outdated
@tseavertseaver changed the title Enable support for 3.10feat: add support for Python 3.10Dec 29, 2021
requirements{,-test}.txt are clean up to remove things that are not
needed for tests to pass and to include newer versions of dependencies.
@aucampia

Copy link
Copy Markdown
ContributorAuthor

Re-checked nox in samples/snippets:

====================================================================== 2 passed, 6 warnings in 30.16s =======================================================================nox > Session py-3.10 was successful.nox > Running session readmegennox > Session readmegen skipped: This session had no parameters available..nox > Ran multiple sessions:nox > * lint: successnox > * blacken: successnox > * py-3.6: successnox > * py-3.7: successnox > * py-3.8: successnox > * py-3.9: successnox > * py-3.10: successnox > * readmegen: skipped20211229T193658 iwana@iwana-pc00.coop.no:~/sw/d/github.com/iafork/python-bigquery-sqlalchemy/samples/snippets
$ 

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'll work on getting the system tests passing so that we can merge this soon.

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 30, 2021
@tswast
tswast merged commit 4b3505b into googleapis:mainDec 30, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.10 support

4 participants

@aucampia@tseaver@tswast@yoshi-kokoro