Skip to content
This repository was archived by the owner on May 16, 2026. It is now read-only.

chore: addressed lint issue with __version__ - #534

Merged
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
issue533-version
Nov 30, 2022
Merged

chore: addressed lint issue with __version__#534
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
issue533-version

Conversation

@thejaredchapman

@thejaredchapmanthejaredchapman commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#533 🦕

@thejaredchapman
thejaredchapman requested review from a team and aribrayNovember 30, 2022 17:08
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Nov 30, 2022

@aribrayaribray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aribrayaribray added the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 4e17259 into mainNov 30, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the issue533-version branch November 30, 2022 17:32
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2022
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Dec 19, 2022
Revert "docs: fix changelog header to consistent size (googleapis#461)"
This reverts commit 177e70a.
Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"
This reverts commit acc9274.
Revert "chore(main): release 1.4.4 (googleapis#462)"
This reverts commit 06c0270.
Revert "fix: require python 3.7+ (googleapis#468)"
This reverts commit 52ec808.
Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"
This reverts commit e894dfa.
Revert "chore: add hashes to requirements.txt' (googleapis#483)"
This reverts commit cc13fe3.
Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"
This reverts commit 484d524.
Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"
This reverts commit 4f90d90.
Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"
This reverts commit 4b37fed.
Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"
This reverts commit 9ffc736.
Revert "chore(deps): update all dependencies (googleapis#488)"
This reverts commit 189af9b.
Revert "chore: detect samples tests in nested directories (googleapis#492)"
This reverts commit f566371.
Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"
This reverts commit 4f72d4e.
Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"
This reverts commit f188944.
Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"
This reverts commit be63adc.
Revert "fix: updates test to account for UTC in failing test (googleapis#501)"
This reverts commit a050ccf.
Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"
This reverts commit 0f6be67.
Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"
This reverts commit bb7f6a7.
Revert "chore(main): release 1.5.0 (googleapis#469)"
This reverts commit 1ffab57.
Revert "chore: addressed lint issue with __version__ (googleapis#534)"
This reverts commit 4e17259.
Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"
This reverts commit 57794c3.
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Mar 16, 2023
Revert "docs: fix changelog header to consistent size (googleapis#461)"
This reverts commit 177e70a.
Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"
This reverts commit acc9274.
Revert "chore(main): release 1.4.4 (googleapis#462)"
This reverts commit 06c0270.
Revert "fix: require python 3.7+ (googleapis#468)"
This reverts commit 52ec808.
Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"
This reverts commit e894dfa.
Revert "chore: add hashes to requirements.txt' (googleapis#483)"
This reverts commit cc13fe3.
Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"
This reverts commit 484d524.
Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"
This reverts commit 4f90d90.
Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"
This reverts commit 4b37fed.
Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"
This reverts commit 9ffc736.
Revert "chore(deps): update all dependencies (googleapis#488)"
This reverts commit 189af9b.
Revert "chore: detect samples tests in nested directories (googleapis#492)"
This reverts commit f566371.
Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"
This reverts commit 4f72d4e.
Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"
This reverts commit f188944.
Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"
This reverts commit be63adc.
Revert "fix: updates test to account for UTC in failing test (googleapis#501)"
This reverts commit a050ccf.
Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"
This reverts commit 0f6be67.
Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"
This reverts commit bb7f6a7.
Revert "chore(main): release 1.5.0 (googleapis#469)"
This reverts commit 1ffab57.
Revert "chore: addressed lint issue with __version__ (googleapis#534)"
This reverts commit 4e17259.
Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"
This reverts commit 57794c3.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose sqlalchemy_bigquery.__version__ property

2 participants

@thejaredchapman@aribray