Skip to content
This repository was archived by the owner on May 16, 2026. It is now read-only.

Compile array columns. - #64

Merged
tswast merged 1 commit into
googleapis:masterfrom
jmcarp:compile-arrays
Nov 18, 2020
Merged

Compile array columns.#64
tswast merged 1 commit into
googleapis:masterfrom
jmcarp:compile-arrays

Conversation

@jmcarp

@jmcarpjmcarp commented Sep 6, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Generate bigquery ddl for array columns and add tests.

cc @tswast@mxmzdlv

@jmcarp

jmcarp commented Nov 17, 2020

Copy link
Copy Markdown
ContributorAuthor

Ping @tswast@mxmzdlv. Do you have time to look at this? It's a very small change.

tswast
tswast approved these changes Nov 18, 2020
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you.

@tswast

tswast commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

Confirmed locally that tests are passing.

@tswast
tswast merged commit db971fb into googleapis:masterNov 18, 2020
@JacobHayesJacobHayes mentioned this pull request Jan 26, 2021
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmcarp@tswast