Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

feat: add always_use_jwt_access - #223

Merged
tswast merged 3 commits into
masterfrom
owl-bot-ea4f74f1-082b-465b-9597-a47a135ab1d2
Jul 1, 2021
Merged

feat: add always_use_jwt_access#223
tswast merged 3 commits into
masterfrom
owl-bot-ea4f74f1-082b-465b-9597-a47a135ab1d2

Conversation

@gcf-owl-bot

Copy link
Copy Markdown
Contributor

fix: disable always_use_jwt_access

Committer: @busunkim96
PiperOrigin-RevId: 382142900

Source-Link: googleapis/googleapis@513440f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0

fix: disable always_use_jwt_access
Committer: @busunkim96
PiperOrigin-RevId: 382142900
Source-Link: googleapis/googleapis@513440f
Source-Link: googleapis/googleapis-gen@7b1e2c3
@gcf-owl-bot
gcf-owl-botBot requested review from a team and tswast and removed request for a teamJune 29, 2021 22:32
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 29, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2021
@product-auto-labelproduct-auto-labelBot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jun 29, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2021
@partheaparthea changed the title chore: use gapic-generator-python 0.50.3fix: disable always_use_jwt_accessJun 30, 2021
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 30, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 30, 2021

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a bunch of failures in the unit-3.7 session.

> return grpc.secure_channel(target, composite_credentials, **kwargs)
E TypeError: secure_channel() got an unexpected keyword argument 'default_scopes'

I suspect there needs to be a bump to the minimum versions somewhere (grpcio?)

@busunkim96busunkim96 changed the title fix: disable always_use_jwt_accessfeat: add always_use_jwt_accessJun 30, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021
@busunkim96
busunkim96 requested a review from tswastJune 30, 2021 21:57
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2021
@tswast
tswast merged commit fd82417 into masterJul 1, 2021
@tswast
tswast deleted the owl-bot-ea4f74f1-082b-465b-9597-a47a135ab1d2 branch July 1, 2021 15:02
@tswast

Copy link
Copy Markdown
Contributor

Thanks for the fix @busunkim96 !

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorageIssues related to the googleapis/python-bigquery-storage API.cla: yesThis human has signed the Contributor License Agreement.owl-bot-copy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@parthea@yoshi-kokoro@busunkim96